Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2343013005:
Fix typo in iOS autofill js: s/fieldset/fieldsets/ (Closed)
|
Created:
4 years, 3 months ago by Frankie Dintino Modified:
4 years, 3 months ago CC:
chromium-reviews, rouslan+autofill_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix typo in iOS autofill js: s/fieldset/fieldsets/
In the getUnownedAutofillableFormFieldElements_() function for iOS
autofill, inside a conditional that is triggered if a <fieldset> is not
a descendant of a <form> element, there is a line that appends an element
to a non-existant variable `fieldset` when it is clear that `fieldsets`
is what was intended.
BUG=570095
R=jif@chromium.org
Committed: https://crrev.com/523102a00566c9413336a03ecab1fd0458c969a6
Cr-Commit-Position: refs/heads/master@{#419498}
Patch Set 1 #Patch Set 2 : Fix typo in iOS autofill js: s/fieldset/fieldsets/ #Messages
Total messages: 25 (11 generated)
Description was changed from ========== Fix typo in iOS autofill js: s/fieldset/fieldsets/ In the getUnownedAutofillableFormFieldElements_() function for iOS autofill, inside a conditional that is triggered if a <fieldset> is not an ancestor of a <form> element, there is a line that appends an element to a non-existant variable `fieldset` when it is clear that `fieldsets` was what was intended. BUG=570095 R=jif@chromium.org ========== to ========== Fix typo in iOS autofill js: s/fieldset/fieldsets/ In the getUnownedAutofillableFormFieldElements_() function for iOS autofill, inside a conditional that is triggered if a <fieldset> is not a descendant of a <form> element, there is a line that appends an element to a non-existant variable `fieldset` when it is clear that `fieldsets` is what was intended. BUG=570095 R=jif@chromium.org ==========
jif@google.com changed reviewers: + jif@google.com
Definitely LGTM, thanks a lot. Adding jdonnelly@ for the OWNER check.
jdonnelly@chromium.org changed reviewers: + jdonnelly@chromium.org
lgtm Thanks for the fix.
The CQ bit was checked by jif@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
The author fdintino@theatlantic.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign and manage CLA.
Frankie, can you visit and sign the CLA?
Sure. Should be signed now.
The CQ bit was checked by jif@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
On 2016/09/19 16:27:56, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) Apparently the presubmit script requires you to add your name to src/AUTHORS.
I’ve added myself to AUTHORS and updated the patch. -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was checked by jif@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from jif@google.com, jdonnelly@chromium.org Link to the patchset: https://codereview.chromium.org/2343013005/#ps20001 (title: "Fix typo in iOS autofill js: s/fieldset/fieldsets/")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix typo in iOS autofill js: s/fieldset/fieldsets/ In the getUnownedAutofillableFormFieldElements_() function for iOS autofill, inside a conditional that is triggered if a <fieldset> is not a descendant of a <form> element, there is a line that appends an element to a non-existant variable `fieldset` when it is clear that `fieldsets` is what was intended. BUG=570095 R=jif@chromium.org ========== to ========== Fix typo in iOS autofill js: s/fieldset/fieldsets/ In the getUnownedAutofillableFormFieldElements_() function for iOS autofill, inside a conditional that is triggered if a <fieldset> is not a descendant of a <form> element, there is a line that appends an element to a non-existant variable `fieldset` when it is clear that `fieldsets` is what was intended. BUG=570095 R=jif@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix typo in iOS autofill js: s/fieldset/fieldsets/ In the getUnownedAutofillableFormFieldElements_() function for iOS autofill, inside a conditional that is triggered if a <fieldset> is not a descendant of a <form> element, there is a line that appends an element to a non-existant variable `fieldset` when it is clear that `fieldsets` is what was intended. BUG=570095 R=jif@chromium.org ========== to ========== Fix typo in iOS autofill js: s/fieldset/fieldsets/ In the getUnownedAutofillableFormFieldElements_() function for iOS autofill, inside a conditional that is triggered if a <fieldset> is not a descendant of a <form> element, there is a line that appends an element to a non-existant variable `fieldset` when it is clear that `fieldsets` is what was intended. BUG=570095 R=jif@chromium.org Committed: https://crrev.com/523102a00566c9413336a03ecab1fd0458c969a6 Cr-Commit-Position: refs/heads/master@{#419498} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/523102a00566c9413336a03ecab1fd0458c969a6 Cr-Commit-Position: refs/heads/master@{#419498}
Message was sent while issue was closed.
Looks like https://codereview.chromium.org/2343753002/ was written before this, but this was reviewed first because I wasn't around last week. |
