Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1655)

Unified Diff: third_party/WebKit/Source/core/fetch/FetchContext.h

Issue 2343623002: Add a warning whenever link preloads are not used (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/FetchContext.h
diff --git a/third_party/WebKit/Source/core/fetch/FetchContext.h b/third_party/WebKit/Source/core/fetch/FetchContext.h
index b3de9b7bbbc974fb9f79ca01586d045c1ad23c15..e7cc86f12f3724fa4ae269d59e9affc1af25d400 100644
--- a/third_party/WebKit/Source/core/fetch/FetchContext.h
+++ b/third_party/WebKit/Source/core/fetch/FetchContext.h
@@ -36,6 +36,7 @@
#include "core/fetch/FetchInitiatorInfo.h"
#include "core/fetch/FetchRequest.h"
#include "core/fetch/Resource.h"
+#include "core/inspector/ConsoleTypes.h"
Yoav Weiss 2016/09/14 11:53:35 I shouldn't be including this (as fetch shouldn't
Charlie Harrison 2016/09/14 12:34:58 It isn't a great solution but you could just add a
Yoav Weiss 2016/09/14 13:28:31 Yeah, I'll go with the latter.
#include "platform/heap/Handle.h"
#include "platform/network/ResourceLoadPriority.h"
#include "wtf/Noncopyable.h"
@@ -101,7 +102,7 @@ public:
virtual bool pageDismissalEventBeingDispatched() const { return false; }
virtual bool updateTimingInfoForIFrameNavigation(ResourceTimingInfo*) { return false; }
virtual void sendImagePing(const KURL&);
- virtual void addConsoleMessage(const String&) const;
+ virtual void addConsoleMessage(const String&, MessageLevel = ErrorMessageLevel) const;
virtual SecurityOrigin* getSecurityOrigin() const { return nullptr; }
virtual void upgradeInsecureRequest(ResourceRequest&);
virtual void addClientHintsIfNecessary(FetchRequest&);

Powered by Google App Engine
This is Rietveld 408576698