Add a warning whenever link preloads are not used

third_party/WebKit/Source/core/fetch/FetchContext.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 18 matching lines @@
  */
 
 #ifndef FetchContext_h
 #define FetchContext_h
 
 #include "core/CoreExport.h"
 #include "core/fetch/CachePolicy.h"
 #include "core/fetch/FetchInitiatorInfo.h"
 #include "core/fetch/FetchRequest.h"
 #include "core/fetch/Resource.h"
+#include "core/inspector/ConsoleTypes.h"

[Yoav Weiss, 2016/09/14 11:53:35]

I shouldn't be including this (as fetch shouldn't include anything from the rest
of core/), btu found no other way to define MessageLevel below with a default
value. Advice on the proper way to do this would be appreciated.

[Charlie Harrison, 2016/09/14 12:34:58]

It isn't a great solution but you could just add another method
"addConsoleErrorMessage" / "addConsoleWarningMessage". Maybe a better strategy
would be to use an enum that translates to the MessageLevel. Think: there are
multiple consumers of this API that should conform, and inspector is just one of
them.

[Yoav Weiss, 2016/09/14 13:28:31]

Yeah, I'll go with the latter.

 #include "platform/heap/Handle.h"
 #include "platform/network/ResourceLoadPriority.h"
 #include "wtf/Noncopyable.h"
 
 namespace blink {
 
 class KURL;
 class MHTMLArchive;
 class ResourceError;
 class ResourceLoader;
@@ skipping 45 matching lines @@
 
     virtual bool isControlledByServiceWorker() const { return false; }
     virtual int64_t serviceWorkerID() const { return -1; }
 
     virtual bool isMainFrame() const { return true; }
     virtual bool defersLoading() const { return false; }
     virtual bool isLoadComplete() const { return false; }
     virtual bool pageDismissalEventBeingDispatched() const { return false; }
     virtual bool updateTimingInfoForIFrameNavigation(ResourceTimingInfo*) { return false; }
     virtual void sendImagePing(const KURL&);
-    virtual void addConsoleMessage(const String&) const;
+    virtual void addConsoleMessage(const String&, MessageLevel = ErrorMessageLevel) const;
     virtual SecurityOrigin* getSecurityOrigin() const { return nullptr; }
     virtual void upgradeInsecureRequest(ResourceRequest&);
     virtual void addClientHintsIfNecessary(FetchRequest&);
     virtual void addCSPHeaderIfNecessary(Resource::Type, FetchRequest&);
     virtual void populateRequestData(ResourceRequest&);
 
     virtual MHTMLArchive* archive() const { return nullptr; }
 
     virtual ResourceLoadPriority modifyPriorityForExperiments(ResourceLoadPriority priority) { return priority; }
 
     virtual WebTaskRunner* loadingTaskRunner() const { return nullptr; }
 
 protected:
     FetchContext() { }
 };
 
 } // namespace blink
 
 #endif