Change the default value of the fetching_requires_signin parameter

Change the default value of the fetching_requires_signin parameter

With the current default value fetching_requires_signin=true, users get
suboptimal UX after fresh install / after clearing app data. Because of
bug 632199, the server-side variation parameters are not applied in the
first run and sign-in is required. This is inconsistent with the second
run of Chrome, where the server sets fetching_requires_signin:=false
and no sign-in is required any more.

BUG=646759
Committed: https://crrev.com/c9be4526b76c9325ad29996f1eff185e3ff87535
Cr-Commit-Position: refs/heads/master@{#419147}

[jkrcal, 2016-09-14 09:50:14]

jkrcal@chromium.org changed reviewers:
+ treib@chromium.org

[jkrcal, 2016-09-14 09:50:15]

PTAL.

[Marc Treib, 2016-09-14 09:52:23]

lgtm

https://codereview.chromium.org/2343583002/diff/1/components/ntp_snippets/ntp...
File components/ntp_snippets/ntp_snippets_status_service_unittest.cc (right):

https://codereview.chromium.org/2343583002/diff/1/components/ntp_snippets/ntp...
components/ntp_snippets/ntp_snippets_status_service_unittest.cc:42: // the
parameter is overriden.
Can you link a bug?

[jkrcal, 2016-09-14 10:18:55]

Thanks, Marc.

https://codereview.chromium.org/2343583002/diff/1/components/ntp_snippets/ntp...
File components/ntp_snippets/ntp_snippets_status_service_unittest.cc (right):

https://codereview.chromium.org/2343583002/diff/1/components/ntp_snippets/ntp...
components/ntp_snippets/ntp_snippets_status_service_unittest.cc:42: // the
parameter is overriden.
On 2016/09/14 09:52:23, Marc Treib wrote:
> Can you link a bug?

Done.

[jkrcal, 2016-09-14 10:19:01]

The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 10:19:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 10:51:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 10:51:09]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jkrcal, 2016-09-14 12:11:37]

The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 12:11:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 12:42:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 12:42:45]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[jkrcal, 2016-09-15 11:18:11]

The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 11:18:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 11:59:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 11:59:51]

Dry run: This issue passed the CQ dry run.

[jkrcal, 2016-09-16 11:43:32]

The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 11:43:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 12:23:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 12:23:28]

Dry run: This issue passed the CQ dry run.

[jkrcal, 2016-09-16 12:26:58]

The CQ bit was checked by jkrcal@chromium.org

[jkrcal, 2016-09-16 12:26:58]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org
Link to the patchset: https://codereview.chromium.org/2343583002/#ps80001
(title: "Reverting the unittest experiment")

[commit-bot: I haz the power, 2016-09-16 12:27:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 12:32:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 12:32:44]

Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/pending/heads/master'.
nothing to commit, working tree clean

[commit-bot: I haz the power, 2016-09-16 12:35:06]

Description was changed from

==========
Change the default value of the fetching_requires_signin parameter

With the current default value fetching_requires_signin=true, users get
suboptimal UX after fresh install / after clearing app data. Because of
bug 632199, the server-side variation parameters are not applied in the
first run and sign-in is required. This is inconsistent with the second
run of Chrome, where the server sets fetching_requires_signin:=false
and no sign-in is required any more.

BUG=646759
==========

to

==========
Change the default value of the fetching_requires_signin parameter

With the current default value fetching_requires_signin=true, users get
suboptimal UX after fresh install / after clearing app data. Because of
bug 632199, the server-side variation parameters are not applied in the
first run and sign-in is required. This is inconsistent with the second
run of Chrome, where the server sets fetching_requires_signin:=false
and no sign-in is required any more.

BUG=646759

Committed: https://crrev.com/c9be4526b76c9325ad29996f1eff185e3ff87535
Cr-Commit-Position: refs/heads/master@{#419147}
==========

[commit-bot: I haz the power, 2016-09-16 12:35:07]

Patchset 5 (id:??) landed as
https://crrev.com/c9be4526b76c9325ad29996f1eff185e3ff87535
Cr-Commit-Position: refs/heads/master@{#419147}