Change the default value of the fetching_requires_signin parameter

components/ntp_snippets/ntp_snippets_status_service_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/ntp_snippets_status_service.h"
 
 #include <memory>
 
 #include "components/ntp_snippets/ntp_snippets_test_utils.h"
 #include "components/ntp_snippets/pref_names.h"
@@ skipping 19 matching lines @@
 
   std::unique_ptr<NTPSnippetsStatusService> MakeService() {
     return base::MakeUnique<NTPSnippetsStatusService>(
         utils_.fake_signin_manager(), utils_.pref_service());
   }
 
  protected:
   test::NTPSnippetsTestUtils utils_;
 };
 
-TEST_F(NTPSnippetsStatusServiceTest, SigninStateCompatibility) {
-  auto service = MakeService();
-
-  // The default test setup is signed out.
-  EXPECT_EQ(DisabledReason::SIGNED_OUT, service->GetDisabledReasonFromDeps());
-
-  // Once signed in, we should be in a compatible state.
-  utils_.fake_signin_manager()->SignIn("foo@bar.com");
-  EXPECT_EQ(DisabledReason::NONE, service->GetDisabledReasonFromDeps());
-}
-
+// TODO(jkrcal): Extend the ways to override variation parameters in unit-test,
+// and recover the SigninStateCompatibility test that sign-in is required when
+// the parameter is overriden.

[Marc Treib, 2016/09/14 09:52:23]

Can you link a bug?

[jkrcal, 2016/09/14 10:18:55]

Done.

 TEST_F(NTPSnippetsStatusServiceTest, DisabledViaPref) {
   auto service = MakeService();
 
-  // The default test setup is signed out.
-  ASSERT_EQ(DisabledReason::SIGNED_OUT, service->GetDisabledReasonFromDeps());
+  // The default test setup is signed out. The service is enabled.
+  ASSERT_EQ(DisabledReason::NONE, service->GetDisabledReasonFromDeps());
 
   // Once the enabled pref is set to false, we should be disabled.
   utils_.pref_service()->SetBoolean(prefs::kEnableSnippets, false);
   EXPECT_EQ(DisabledReason::EXPLICITLY_DISABLED,
             service->GetDisabledReasonFromDeps());
 
-  // The other dependencies shouldn't matter anymore.
+  // Signing-in shouldn't matter anymore.
   utils_.fake_signin_manager()->SignIn("foo@bar.com");
   EXPECT_EQ(DisabledReason::EXPLICITLY_DISABLED,
             service->GetDisabledReasonFromDeps());
 }
 
 }  // namespace ntp_snippets