Use git ls-tree to collect source files instead of walking the fs

Use git ls-tree to collect source files instead of walking the fs

Also remove obsolete oom_dump sources.

R=machenbach@chromium.org
BUG=

Committed: https://crrev.com/5e113c72415c2f8ce0123a4ddec6d1154bb743dd
Cr-Commit-Position: refs/heads/master@{#39527}

[jochen (gone - plz use gerrit), 2016-09-19 13:17:18]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 13:17:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-09-19 13:17:36]

with https://codereview.chromium.org/2348283002 we should be able to remove
"testing" from the list of unsupported features

[commit-bot: I haz the power, 2016-09-19 13:43:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 13:43:48]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2016-09-19 15:08:21]

https://codereview.chromium.org/2343423002/diff/1/tools/verify_source_deps.py
File tools/verify_source_deps.py (right):

https://codereview.chromium.org/2343423002/diff/1/tools/verify_source_deps.py...
tools/verify_source_deps.py:36: os.path.join(V8_BASE, 'testing', 'gmock.gyp'),
Why do we need to list third_party gyp files?

[Michael Achenbach, 2016-09-19 15:09:37]

https://codereview.chromium.org/2343423002/diff/1/tools/verify_source_deps.py
File tools/verify_source_deps.py (right):

https://codereview.chromium.org/2343423002/diff/1/tools/verify_source_deps.py...
tools/verify_source_deps.py:23: V8_SRC_BASE = os.path.join(V8_BASE, 'src')
So these would be unused now?

[jochen (gone - plz use gerrit), 2016-09-19 15:11:46]

https://codereview.chromium.org/2343423002/diff/1/tools/verify_source_deps.py
File tools/verify_source_deps.py (right):

https://codereview.chromium.org/2343423002/diff/1/tools/verify_source_deps.py...
tools/verify_source_deps.py:23: V8_SRC_BASE = os.path.join(V8_BASE, 'src')
On 2016/09/19 at 15:09:37, machenbach (slow) wrote:
> So these would be unused now?

right, will remove

https://codereview.chromium.org/2343423002/diff/1/tools/verify_source_deps.py...
tools/verify_source_deps.py:36: os.path.join(V8_BASE, 'testing', 'gmock.gyp'),
On 2016/09/19 at 15:08:21, machenbach (slow) wrote:
> Why do we need to list third_party gyp files?

it's not third_party, but checked into v8

[Michael Achenbach, 2016-09-19 15:12:48]

https://codereview.chromium.org/2343423002/diff/1/tools/verify_source_deps.py
File tools/verify_source_deps.py (right):

https://codereview.chromium.org/2343423002/diff/1/tools/verify_source_deps.py...
tools/verify_source_deps.py:102: cmd = ['git', 'ls-tree', '-r', 'HEAD',
'--full-name', '--name-only']
This might now work on windows (not sure if that's a goal). Might require
git.bat

https://codereview.chromium.org/2343423002/diff/1/tools/verify_source_deps.py...
tools/verify_source_deps.py:103: for f in
subprocess.check_output(cmd).split('\n'):
Unlikely that this fails after it first works, but if it does, I guess we won't
see the output.

[Michael Achenbach, 2016-09-19 15:13:16]

https://codereview.chromium.org/2343423002/diff/1/tools/verify_source_deps.py
File tools/verify_source_deps.py (right):

https://codereview.chromium.org/2343423002/diff/1/tools/verify_source_deps.py...
tools/verify_source_deps.py:102: cmd = ['git', 'ls-tree', '-r', 'HEAD',
'--full-name', '--name-only']
On 2016/09/19 15:12:48, machenbach (slow) wrote:
> This might now work on windows (not sure if that's a goal). Might require
> git.bat

And with now I mean not :)

[jochen (gone - plz use gerrit), 2016-09-19 15:14:39]

https://codereview.chromium.org/2343423002/diff/1/tools/verify_source_deps.py
File tools/verify_source_deps.py (right):

https://codereview.chromium.org/2343423002/diff/1/tools/verify_source_deps.py...
tools/verify_source_deps.py:102: cmd = ['git', 'ls-tree', '-r', 'HEAD',
'--full-name', '--name-only']
On 2016/09/19 at 15:13:16, machenbach (slow) wrote:
> On 2016/09/19 15:12:48, machenbach (slow) wrote:
> > This might now work on windows (not sure if that's a goal). Might require
> > git.bat
> 
> And with now I mean not :)

Well, I developed this CL on windows... :)

but I'm using mingw, I can try with cmd as well

https://codereview.chromium.org/2343423002/diff/1/tools/verify_source_deps.py...
tools/verify_source_deps.py:103: for f in
subprocess.check_output(cmd).split('\n'):
On 2016/09/19 at 15:12:48, machenbach (slow) wrote:
> Unlikely that this fails after it first works, but if it does, I guess we
won't see the output.

ah, I guess I forgot to add universal_newlines=True

[Michael Achenbach, 2016-09-19 15:16:30]

lgtm

rubber-stamp on oomdump removal. Maybe explain in CL desc?

https://codereview.chromium.org/2343423002/diff/1/tools/verify_source_deps.py
File tools/verify_source_deps.py (right):

https://codereview.chromium.org/2343423002/diff/1/tools/verify_source_deps.py...
tools/verify_source_deps.py:36: os.path.join(V8_BASE, 'testing', 'gmock.gyp'),
On 2016/09/19 15:11:46, jochen wrote:
> On 2016/09/19 at 15:08:21, machenbach (slow) wrote:
> > Why do we need to list third_party gyp files?
> 
> it's not third_party, but checked into v8 

Acknowledged.

https://codereview.chromium.org/2343423002/diff/1/tools/verify_source_deps.py...
tools/verify_source_deps.py:102: cmd = ['git', 'ls-tree', '-r', 'HEAD',
'--full-name', '--name-only']
On 2016/09/19 15:14:39, jochen wrote:
> On 2016/09/19 at 15:13:16, machenbach (slow) wrote:
> > On 2016/09/19 15:12:48, machenbach (slow) wrote:
> > > This might now work on windows (not sure if that's a goal). Might require
> > > git.bat
> > 
> > And with now I mean not :)
> 
> Well, I developed this CL on windows... :)
> 
> but I'm using mingw, I can try with cmd as well

Don't bother.

[jochen (gone - plz use gerrit), 2016-09-20 07:04:01]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 07:04:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-09-20 07:04:24]

Description was changed from

==========
Use git ls-tree to collect source files instead of walking the fs

R=machenbach@chromium.org
BUG=
==========

to

==========
Use git ls-tree to collect source files instead of walking the fs

Also remove obsolete oom_dump sources.

R=machenbach@chromium.org
BUG=
==========

[jochen (gone - plz use gerrit), 2016-09-20 07:04:28]

The CQ bit was unchecked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-09-20 07:04:30]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-09-20 07:04:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2343423002/#ps20001
(title: "updates")

[commit-bot: I haz the power, 2016-09-20 07:04:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 07:27:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-20 07:28:19]

Description was changed from

==========
Use git ls-tree to collect source files instead of walking the fs

Also remove obsolete oom_dump sources.

R=machenbach@chromium.org
BUG=
==========

to

==========
Use git ls-tree to collect source files instead of walking the fs

Also remove obsolete oom_dump sources.

R=machenbach@chromium.org
BUG=

Committed: https://crrev.com/5e113c72415c2f8ce0123a4ddec6d1154bb743dd
Cr-Commit-Position: refs/heads/master@{#39527}
==========

[commit-bot: I haz the power, 2016-09-20 07:28:20]

Patchset 2 (id:??) landed as
https://crrev.com/5e113c72415c2f8ce0123a4ddec6d1154bb743dd
Cr-Commit-Position: refs/heads/master@{#39527}