Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2348283002: Add gmock helper to the BUILD.gn files (Closed)

Created:
4 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add gmock helper to the BUILD.gn files R=dpranke@chromium.org BUG= Committed: https://crrev.com/03f3d50ebcc6ed52ef450846d882e35f3dc3d12f Cr-Commit-Position: refs/heads/master@{#419495}

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/secondary/testing/gmock/BUILD.gn View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
jochen (gone - plz use gerrit)
ptal
4 years, 3 months ago (2016-09-19 13:45:38 UTC) #11
jochen (gone - plz use gerrit)
there's also gmock_mutant.h and a bunch of other headers that aren't referenced, however, those aren't ...
4 years, 3 months ago (2016-09-19 14:11:05 UTC) #15
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-19 17:17:51 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348283002/40001
4 years, 3 months ago (2016-09-19 17:23:01 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-19 17:28:49 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 17:30:54 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/03f3d50ebcc6ed52ef450846d882e35f3dc3d12f
Cr-Commit-Position: refs/heads/master@{#419495}

Powered by Google App Engine
This is Rietveld 408576698