[Download Home] Open supported files in Custom Tabs

[Download Home] Open supported files in Custom Tabs

Downloads stuff:
* Add a function to DownloadManagerService that queries whether
  a MIME type is supported for display in Chrome.

* When opening a file via Download Home, query whether the file
  type is supported.  If so, send it to a new tab instead of
  Intenting out.

* Move Share and View intent code out to DownloadUtils and expose
  constants everywhere to allow this to happen.

* Removed periods from download notification Strings.

Custom Tab stuff:
* Added a "media viewer" intent extra that makes Custom Tabs
  opened by Download Home hide unnecessary menu items.

BUG=616324, 648454
Committed: https://crrev.com/4876f0de97118aedbba17f973387bab3f539120a
Cr-Commit-Position: refs/heads/master@{#419921}

[gone, 2016-09-20 01:09:36]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 01:10:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2016-09-20 01:10:52]

dfalcantara@chromium.org changed reviewers:
+ ianwen@chromium.org, qinmin@chromium.org, twellington@chromium.org

[gone, 2016-09-20 01:10:53]

Min for the DownloadManager stuff.
Theresa for the DownloadUtils stuff I moved.
Ian for the Custom Tab stuff I added.
Whiskey for everybody.

[commit-bot: I haz the power, 2016-09-20 01:14:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 01:14:39]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[gone, 2016-09-20 16:31:07]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 16:31:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 17:03:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 17:03:04]

Dry run: This issue passed the CQ dry run.

[qinmin, 2016-09-20 19:05:22]

DownloadManagerService.java/download_manager_service.cc(h) lgtm

[Theresa, 2016-09-20 20:04:12]

lgtm

https://codereview.chromium.org/2343363005/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
(right):

https://codereview.chromium.org/2343363005/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java:176:
public static Intent createShareIntent(List<DownloadHistoryItemWrapper>
selectedItems) {
nit: s/selectedItems/items?

Also, add a JavaDoc for this method. Maybe something like "Creates an Intent to
share {@code items} with another app by firing an Intent to Android."

Or it could be more detailed -- "Shares the files associated with DownloadItems
and the URLs associated with OfflinePageItems."

[Ian Wen, 2016-09-20 21:15:55]

lgtm for custom tab stuff.

https://codereview.chromium.org/2343363005/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java
(right):

https://codereview.chromium.org/2343363005/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java:105:
readItLaterItem.setVisible(false);
No need to care about read it later. I am removing it very soon.

[gone, 2016-09-20 21:56:08]

https://codereview.chromium.org/2343363005/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java
(right):

https://codereview.chromium.org/2343363005/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java:105:
readItLaterItem.setVisible(false);
On 2016/09/20 21:15:55, Ian Wen wrote:
> No need to care about read it later. I am removing it very soon.

I've mucked up the revert you were planning by doing the if statement, so
this'll have to be revisited anyway.

https://codereview.chromium.org/2343363005/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
(right):

https://codereview.chromium.org/2343363005/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java:176:
public static Intent createShareIntent(List<DownloadHistoryItemWrapper>
selectedItems) {
On 2016/09/20 20:04:12, Theresa Wellington wrote:
> nit: s/selectedItems/items?
> 
> Also, add a JavaDoc for this method. Maybe something like "Creates an Intent
to
> share {@code items} with another app by firing an Intent to Android."
> 
> Or it could be more detailed -- "Shares the files associated with
DownloadItems
> and the URLs associated with OfflinePageItems."

Did some variant.

[gone, 2016-09-20 21:56:14]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-09-20 21:56:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org, qinmin@chromium.org, ianwen@chromium.org
Link to the patchset: https://codereview.chromium.org/2343363005/#ps40001
(title: "Comments")

[commit-bot: I haz the power, 2016-09-20 21:56:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 00:42:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-21 00:44:06]

Description was changed from

==========
[Download Home] Open supported files in Custom Tabs

Downloads stuff:
* Add a function to DownloadManagerService that queries whether
  a MIME type is supported for display in Chrome.

* When opening a file via Download Home, query whether the file
  type is supported.  If so, send it to a new tab instead of
  Intenting out.

* Move Share and View intent code out to DownloadUtils and expose
  constants everywhere to allow this to happen.

* Removed periods from download notification Strings.

Custom Tab stuff:
* Added a "media viewer" intent extra that makes Custom Tabs
  opened by Download Home hide unnecessary menu items.

BUG=616324,648454
==========

to

==========
[Download Home] Open supported files in Custom Tabs

Downloads stuff:
* Add a function to DownloadManagerService that queries whether
  a MIME type is supported for display in Chrome.

* When opening a file via Download Home, query whether the file
  type is supported.  If so, send it to a new tab instead of
  Intenting out.

* Move Share and View intent code out to DownloadUtils and expose
  constants everywhere to allow this to happen.

* Removed periods from download notification Strings.

Custom Tab stuff:
* Added a "media viewer" intent extra that makes Custom Tabs
  opened by Download Home hide unnecessary menu items.

BUG=616324,648454

Committed: https://crrev.com/4876f0de97118aedbba17f973387bab3f539120a
Cr-Commit-Position: refs/heads/master@{#419921}
==========

[commit-bot: I haz the power, 2016-09-21 00:44:07]

Patchset 3 (id:??) landed as
https://crrev.com/4876f0de97118aedbba17f973387bab3f539120a
Cr-Commit-Position: refs/heads/master@{#419921}