Issue 2343303002: Merge "arc: Fix crash on close a notification"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2343303002: Merge "arc: Fix crash on close a notification" (Closed)

Created:
4 years, 3 months ago by xiyuan

Modified:
4 years, 3 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

Merge "arc: Fix crash on close a notification" > Speculative fix of the notification close crash that the underlying > notification surface is changed after the floating close button > is created. > > BUG=646634 > > Review-Url: https://codereview.chromium.org/2338423002 > Cr-Commit-Position: refs/heads/master@{#418881} > (cherry picked from commit 6232937b395e494747b457b3f046c3bb86c65c9c) Committed: https://chromium.googlesource.com/chromium/src/+/d1d17ab9eee5686b46797c80ce69a74d7138e291

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	ui/arc/notification/arc_custom_notification_view.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

xiyuan

4 years, 3 months ago (2016-09-16 22:55:06 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d1d17ab9eee5686b46797c80ce69a74d7138e291.