Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2338423002: arc: Fix crash on close a notification (Closed)

Created:
4 years, 3 months ago by xiyuan
Modified:
4 years, 3 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Fix crash on close a notification Speculative fix of the notification close crash that the underlying notification surface is changed after the floating close button is created. BUG=646634 Committed: https://crrev.com/6232937b395e494747b457b3f046c3bb86c65c9c Cr-Commit-Position: refs/heads/master@{#418881}

Patch Set 1 #

Patch Set 2 : fix comment #

Patch Set 3 : handle surface A->B in addition to A->nullptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ui/arc/notification/arc_custom_notification_view.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
xiyuan
4 years, 3 months ago (2016-09-14 20:43:15 UTC) #5
yoshiki
lgtm
4 years, 3 months ago (2016-09-15 04:35:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338423002/40001
4 years, 3 months ago (2016-09-15 16:10:06 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-15 16:15:21 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 17:10:13 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6232937b395e494747b457b3f046c3bb86c65c9c
Cr-Commit-Position: refs/heads/master@{#418881}

Powered by Google App Engine
This is Rietveld 408576698