Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2343283002: Re-enable rate limiting for Windows Crashpad (Closed)

Created:
4 years, 3 months ago by scottmg
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Re-enable rate limiting for Windows Crashpad Chrome can get itself into crash loops that cause massive numbers of uploads. We'd like to have UMA to see what we're dropping, but for the time being, mitigate by re-instituting the Mac-style 1/hr upload limit. BUG=crashpad:23 Review-Url: https://codereview.chromium.org/2332103002 Cr-Commit-Position: refs/heads/master@{#418063} (cherry picked from commit d922b3cacfcee6958d71de501a8ced7c25801965) Committed: https://chromium.googlesource.com/chromium/src/+/9b50a69f641ced25720eb16e05b7da73879108eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M components/crash/content/app/crashpad_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
scottmg
4 years, 3 months ago (2016-09-16 21:41:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9b50a69f641ced25720eb16e05b7da73879108eb.

Powered by Google App Engine
This is Rietveld 408576698