Issue 2343273002: Fix the disappearance of "Offline" chip from the LocationBar when navigating to a fragment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2343273002: Fix the disappearance of "Offline" chip from the LocationBar when navigating to a fragment. (Closed)

Created:
4 years, 3 months ago by Dmitry Titov

Modified:
4 years, 3 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

Fix the disappearance of "Offline" chip from the LocationBar when navigating to a fragment. BUG=647117 Review-Url: https://codereview.chromium.org/2347723002 Cr-Commit-Position: refs/heads/master@{#419094} (cherry picked from commit c1eac5fc313081e76aaf6286464c448cca581147) Committed: https://chromium.googlesource.com/chromium/src/+/29569d2a466072fe5c0fb57bfd3c33d6a531eb7d

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -26 lines)			Patch
M	chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc	View	12 chunks	+22 lines, -22 lines	0 comments	Download
M	chrome/browser/android/offline_pages/offline_page_tab_helper.h	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/android/offline_pages/offline_page_tab_helper.cc	View	3 chunks	+18 lines, -4 lines	0 comments	Download

Total messages: 2 (1 generated)

Dmitry Titov

4 years, 3 months ago (2016-09-16 21:27:35 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
29569d2a466072fe5c0fb57bfd3c33d6a531eb7d.