components/autofill/core/browser/form_structure.cc - Issue 23432002: Generate passwords only for forms that autofill server marks as account creation forms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/form_structure.cc

Issue 23432002: Generate passwords only for forms that autofill server marks as account creation forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address llya's nits and fix a bug in form structure unit test. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/password_generation_manager.cc ('K') | « components/autofill/core/browser/field_types.h ('k') | components/autofill/core/browser/form_structure_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/form_structure.cc

diff --git a/components/autofill/core/browser/form_structure.cc b/components/autofill/core/browser/form_structure.cc

index 0a534f8d8477889ab748f377660b70fe88ba13c5..cfc57f861f77bcde5eb024a8d92d65c494bb0142 100644

--- a/components/autofill/core/browser/form_structure.cc

+++ b/components/autofill/core/browser/form_structure.cc

@@ -697,8 +697,7 @@ bool FormStructure::IsAutocheckoutEnabled() const {

}

bool FormStructure::ShouldSkipField(const FormFieldData& field) const {

- return (field.is_checkable || field.form_control_type == "password") &&

- !IsAutocheckoutEnabled();

+ return field.is_checkable && !IsAutocheckoutEnabled();

}

size_t FormStructure::RequiredFillableFields() const {