Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: components/autofill/core/browser/field_types.h

Issue 23432002: Generate passwords only for forms that autofill server marks as account creation forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address llya's nits and fix a bug in form structure unit test. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/field_types.h
diff --git a/components/autofill/core/browser/field_types.h b/components/autofill/core/browser/field_types.h
index 081a7a75c42c092b4200d7b1806410d98b1b6ae5..0eda2e278c8f5cb4f5bc8da7fbd26b2429b54d62 100644
--- a/components/autofill/core/browser/field_types.h
+++ b/components/autofill/core/browser/field_types.h
@@ -99,10 +99,22 @@ enum ServerFieldType {
NAME_BILLING_FULL = 71,
NAME_BILLING_SUFFIX = 72,
+ // Field types for options generally found in merchant buyflows. Given that
+ // these are likely to be filled out differently on a case by case basis,
+ // they are here primarly for use by Autocheckout.
+ MERCHANT_EMAIL_SIGNUP = 73,
+ MERCHANT_PROMO_CODE = 74,
+
+ // Field types for the password fields. PASSWORD is the default type for all
+ // password fields. ACCOUNT_CREATION_PASSWORD is the first password field in
+ // an account creation form and will trigger password generation.
+ PASSWORD = 75,
+ ACCOUNT_CREATION_PASSWORD = 76,
+
// No new types can be added without a corresponding change to the Autofill
// server.
- MAX_VALID_FIELD_TYPE = 73,
+ MAX_VALID_FIELD_TYPE = 77,
};
// The list of all HTML autocomplete field type hints supported by Chrome.
@@ -181,6 +193,7 @@ enum FieldTypeGroup {
PHONE_HOME,
PHONE_BILLING,
CREDIT_CARD,
+ PASSWORD_FIELD,
};
typedef std::set<ServerFieldType> ServerFieldTypeSet;

Powered by Google App Engine
This is Rietveld 408576698