components/autofill/core/browser/DEPS - Issue 23432002: Generate passwords only for forms that autofill server marks as account creation forms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/DEPS

Issue 23432002: Generate passwords only for forms that autofill server marks as account creation forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/password_generation_manager.cc ('K') | « components/autofill/content/renderer/password_generation_manager.cc ('k') | components/autofill/core/browser/autofill_manager.cc » ('j') | components/autofill/core/browser/autofill_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/DEPS

diff --git a/components/autofill/core/browser/DEPS b/components/autofill/core/browser/DEPS

index c59b4e2800082826abfab6281354683f4f9c9969..2fe3dbb2cd19072bcab9ccdcb881e34739167866 100644

--- a/components/autofill/core/browser/DEPS

+++ b/components/autofill/core/browser/DEPS

@@ -12,6 +12,7 @@ include_rules = [

# Do not add to the list of temporarily-allowed dependencies below,

# and please do not introduce more #includes of these files.

+ "!chrome/browser/password_manager/password_generation_manager.h",

Garrett Casto 2013/08/29 22:45:13 I don't think that this is okay, but there should

Ilya Sherman 2013/08/29 23:08:13 This is not an acceptable dependency. Please find

zysxqn 2013/09/03 23:00:20 Done.

"!components/autofill/content/browser/autocheckout/whitelist_manager.h",

"!components/autofill/content/browser/autocheckout_manager.h",

"!components/autofill/content/browser/autocheckout_page_meta_data.h",