components/autofill/core/browser/DEPS - Issue 23432002: Generate passwords only for forms that autofill server marks as account creation forms.

Side by Side Diff: components/autofill/core/browser/DEPS

Issue 23432002: Generate passwords only for forms that autofill server marks as account creation forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/autofill/content/renderer/password_generation_manager.cc ('K') | « components/autofill/content/renderer/password_generation_manager.cc ('k') | components/autofill/core/browser/autofill_manager.cc » ('j') | components/autofill/core/browser/autofill_manager.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+components/webdata/common",	2 "+components/webdata/common",

3 "+crypto/random.h",	3 "+crypto/random.h",

4 "+google_apis/gaia",	4 "+google_apis/gaia",

5 "+google_apis/google_api_keys.h",	5 "+google_apis/google_api_keys.h",

6 "+net",	6 "+net",

7 "+sql",	7 "+sql",

8 "+third_party/libjingle",	8 "+third_party/libjingle",

9 "+third_party/libphonenumber", # For phone number i18n.	9 "+third_party/libphonenumber", # For phone number i18n.

10	10

11 # TODO(blundell): Bring this list to zero.	11 # TODO(blundell): Bring this list to zero.

12 #	12 #

13 # Do not add to the list of temporarily-allowed dependencies below,	13 # Do not add to the list of temporarily-allowed dependencies below,

14 # and please do not introduce more #includes of these files.	14 # and please do not introduce more #includes of these files.

	15 "!chrome/browser/password_manager/password_generation_manager.h",
	Garrett Casto 2013/08/29 22:45:13 I don't think that this is okay, but there should I don't think that this is okay, but there should be ways around this. Ilya Sherman 2013/08/29 23:08:13 This is not an acceptable dependency. Please find This is not an acceptable dependency. Please find a way to avoid it, possibly via one of the delegate interfaces like AutofillManagerDelegate. zysxqn 2013/09/03 23:00:20 Done. Show quoted text On 2013/08/29 22:45:13, Garrett Casto wrote: > I don't think that this is okay, but there should be ways around this. Done. zysxqn 2013/09/03 23:00:20 Done. Show quoted text On 2013/08/29 23:08:13, Ilya Sherman wrote: > This is not an acceptable dependency. Please find a way to avoid it, possibly > via one of the delegate interfaces like AutofillManagerDelegate. Done.
15 "!components/autofill/content/browser/autocheckout/whitelist_manager.h",	16 "!components/autofill/content/browser/autocheckout/whitelist_manager.h",

16 "!components/autofill/content/browser/autocheckout_manager.h",	17 "!components/autofill/content/browser/autocheckout_manager.h",

17 "!components/autofill/content/browser/autocheckout_page_meta_data.h",	18 "!components/autofill/content/browser/autocheckout_page_meta_data.h",

18 "!components/autofill/content/browser/autocheckout_steps.h",	19 "!components/autofill/content/browser/autocheckout_steps.h",

19 "!content/public/browser/android/content_view_core.h",	20 "!content/public/browser/android/content_view_core.h",

20 "!content/public/browser/browser_context.h",	21 "!content/public/browser/browser_context.h",

21 "!content/public/browser/browser_thread.h",	22 "!content/public/browser/browser_thread.h",

22 "!content/public/browser/render_view_host.h",	23 "!content/public/browser/render_view_host.h",

23 "!content/public/browser/web_contents.h",	24 "!content/public/browser/web_contents.h",

24 "!content/public/browser/web_contents_observer.h",	25 "!content/public/browser/web_contents_observer.h",

(...skipping 19 matching lines...) Expand all Loading...
44 "!chrome/browser/sync/profile_sync_service.h",	45 "!chrome/browser/sync/profile_sync_service.h",

45 "!chrome/browser/sync/profile_sync_service_factory.h",	46 "!chrome/browser/sync/profile_sync_service_factory.h",

46 "!chrome/browser/ui/autofill/tab_autofill_manager_delegate.h",	47 "!chrome/browser/ui/autofill/tab_autofill_manager_delegate.h",

47 "!chrome/browser/webdata/web_data_service.h",	48 "!chrome/browser/webdata/web_data_service.h",

48 "!chrome/browser/webdata/web_data_service_factory.h",	49 "!chrome/browser/webdata/web_data_service_factory.h",

49 "!chrome/common/chrome_paths.h",	50 "!chrome/common/chrome_paths.h",

50 "!chrome/test/base/chrome_render_view_host_test_harness.h",	51 "!chrome/test/base/chrome_render_view_host_test_harness.h",

51 "!chrome/test/base/testing_profile.h",	52 "!chrome/test/base/testing_profile.h",

52 ],	53 ],

53 }	54 }

OLD	NEW