Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: components/autofill/content/renderer/password_generation_manager.h

Issue 23432002: Generate passwords only for forms that autofill server marks as account creation forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_generation_manager.h
diff --git a/components/autofill/content/renderer/password_generation_manager.h b/components/autofill/content/renderer/password_generation_manager.h
index a61542861677bbef405e9fabb77c9ed2d9939b24..8b3f65613fe1aab45b0526859c727941048e6515 100644
--- a/components/autofill/content/renderer/password_generation_manager.h
+++ b/components/autofill/content/renderer/password_generation_manager.h
@@ -54,6 +54,7 @@ class PasswordGenerationManager : public content::RenderViewObserver,
void OnFormNotBlacklisted(const content::PasswordForm& form);
void OnPasswordAccepted(const base::string16& password);
void OnPasswordGenerationEnabled(bool enabled);
+ void OnAccountCreationFormsDetected(const std::vector<GURL>& origins);
// Helper function to decide whether we should show password generation icon.
void MaybeShowIcon();
@@ -72,6 +73,10 @@ class PasswordGenerationManager : public content::RenderViewObserver,
// passwords for this site".
std::vector<GURL> not_blacklisted_password_form_origins_;
+ // Stores the origins of the password forms that autofill server classifies
+ // one of its fields as ACCOUNT_CREATION_PASSWORD.
Ilya Sherman 2013/08/29 23:08:13 nit: Several small wording tweaks: "Stores the ori
zysxqn 2013/09/03 23:00:20 Done.
+ std::vector<GURL> autofill_account_creation_form_origins_;
+
std::vector<WebKit::WebInputElement> passwords_;
DISALLOW_COPY_AND_ASSIGN(PasswordGenerationManager);

Powered by Google App Engine
This is Rietveld 408576698