Generate passwords only for forms that autofill server marks as account creation forms.

components/autofill/content/renderer/password_generation_manager.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_GENERATION_MANAGER_H_
 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_GENERATION_MANAGER_H_
 
 #include <map>
 #include <utility>
 #include <vector>
@@ skipping 36 matching lines @@
   virtual void DidFinishDocumentLoad(WebKit::WebFrame* frame) OVERRIDE;
   virtual void DidFinishLoad(WebKit::WebFrame* frame) OVERRIDE;
 
   // WebPasswordGeneratorClient:
   virtual void openPasswordGenerator(WebKit::WebInputElement& element) OVERRIDE;
 
   // Message handlers.
   void OnFormNotBlacklisted(const content::PasswordForm& form);
   void OnPasswordAccepted(const base::string16& password);
   void OnPasswordGenerationEnabled(bool enabled);
+  void OnAccountCreationFormsDetected(const std::vector<GURL>& origins);
 
   // Helper function to decide whether we should show password generation icon.
   void MaybeShowIcon();
 
   content::RenderView* render_view_;
 
   // True if password generation is enabled for the profile associated
   // with this renderer.
   bool enabled_;
 
   // Stores the origin of the account creation form we detected.
   GURL account_creation_form_origin_;

[Ilya Sherman, 2013/08/29 23:08:13]

nit: Perhaps update this name to |possible_account_creation_form_origin_|?  It
currently seems pretty weird to see a loop scanning through
autofill_account_creation_form_origins_ looking for
account_creation_form_origin_ -- at first glance, that looks like that search
should always succeed, because of the semantics implied by the names.

[zysxqn, 2013/09/03 23:00:20]

Done.

 
   // Stores the origins of the password forms confirmed not to be blacklisted
   // by the browser. A form can be blacklisted if a user chooses "never save
   // passwords for this site".
   std::vector<GURL> not_blacklisted_password_form_origins_;
 
+  // Stores the origins of the password forms that autofill server classifies
+  // one of its fields as ACCOUNT_CREATION_PASSWORD.

[Ilya Sherman, 2013/08/29 23:08:13]

nit: Several small wording tweaks: "Stores the origin of each password form for
which the Autofill server classifies one of the form's fields as an
ACCOUNT_CREATION_PASSWORD."

[zysxqn, 2013/09/03 23:00:20]

Done.

+  std::vector<GURL> autofill_account_creation_form_origins_;
+
   std::vector<WebKit::WebInputElement> passwords_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordGenerationManager);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_GENERATION_MANAGER_H_