Do not add type information to constants with constructor taking type information

Do not add type information to constants with constructor taking type information

R=sigmund@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/a51d185ff51ce751d9a24d51026249334e55ac26

[Siggi Cherem (dart-lang), 2016-09-16 18:39:02]

https://chromiumcodereview.appspot.com/2343193002/diff/1/pkg/compiler/lib/src...
File pkg/compiler/lib/src/js_backend/constant_emitter.dart (right):

https://chromiumcodereview.appspot.com/2343193002/diff/1/pkg/compiler/lib/src...
pkg/compiler/lib/src/js_backend/constant_emitter.dart:318: return instantiation;
to clarify: is this because the type-information is already passed into the
constructor, so we were practically setting it twice?

[sra1, 2016-09-16 20:09:08]

https://chromiumcodereview.appspot.com/2343193002/diff/1/pkg/compiler/lib/src...
File pkg/compiler/lib/src/js_backend/constant_emitter.dart (right):

https://chromiumcodereview.appspot.com/2343193002/diff/1/pkg/compiler/lib/src...
pkg/compiler/lib/src/js_backend/constant_emitter.dart:318: return instantiation;
On 2016/09/16 18:39:02, Siggi Cherem (dart-lang) wrote:
> to clarify: is this because the type-information is already passed into the
> constructor, so we were practically setting it twice?

Exactly. Line 315.

[Siggi Cherem (dart-lang), 2016-09-16 20:13:51]

lgtm

[sra1, 2016-09-16 22:09:38]

Description was changed from

==========
Do not add type information to constants with constructor taking type
information

R=sigmund@google.com
BUG=
==========

to

==========
Do not add type information to constants with constructor taking type
information

R=sigmund@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/a51d185ff51ce751d9a24d51026249334e55ac26
==========

[sra1, 2016-09-16 22:09:39]

Committed patchset #1 (id:1) manually as
a51d185ff51ce751d9a24d51026249334e55ac26 (presubmit successful).