Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: pkg/compiler/lib/src/js_backend/constant_emitter.dart

Issue 2343193002: Do not add type information to constants with constructor taking type information (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/constant_emitter.dart
diff --git a/pkg/compiler/lib/src/js_backend/constant_emitter.dart b/pkg/compiler/lib/src/js_backend/constant_emitter.dart
index e30ef91bc4d213699020c50008785c3171918a69..31bcccb9c0971aedf79d8526944f2af21ce27a68 100644
--- a/pkg/compiler/lib/src/js_backend/constant_emitter.dart
+++ b/pkg/compiler/lib/src/js_backend/constant_emitter.dart
@@ -315,7 +315,7 @@ class ConstantEmitter implements ConstantValueVisitor<jsAst.Expression, Null> {
fields.add(_reifiedTypeArguments(constant.type));
}
jsAst.New instantiation = new jsAst.New(constructor, fields);
- return maybeAddTypeArguments(constant.type, instantiation);
+ return instantiation;
Siggi Cherem (dart-lang) 2016/09/16 18:39:02 to clarify: is this because the type-information i
sra1 2016/09/16 20:09:08 Exactly. Line 315.
}
String stripComments(String rawJavaScript) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698