[base] Template hashmap on key and value

[base] Template hashmap on key and value

Adds template parameters for the TemplateHashMapImpl for the key and
value type, to allow them to be something other than pointers. To keep
the impact of this patch low, uses of TemplateHashMapImpl set these
types to void* to emulate the previous behaviour.

This is part of a wider set of changes discussed in:
https://groups.google.com/forum/#!topic/v8-dev/QLsC0XPYLeM

Committed: https://crrev.com/696dd65b80904ea9c029c3ce89d2a5307a1f69f6
Cr-Commit-Position: refs/heads/master@{#39530}

[Leszek Swirski, 2016-09-16 14:19:46]

The CQ bit was checked by leszeks@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 14:19:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Leszek Swirski, 2016-09-16 14:21:36]

leszeks@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[rmcilroy, 2016-09-19 10:32:08]

LGTM. Thanks.

https://codereview.chromium.org/2343123002/diff/20001/src/base/hashmap.h
File src/base/hashmap.h (right):

https://codereview.chromium.org/2343123002/diff/20001/src/base/hashmap.h#newc...
src/base/hashmap.h:92: static bool PointersMatch(typename
MatchFunHelper<Key>::KeyRef key1,
Hmm, this isn't really PointersMatch unless Key is a pointer. Not sure what the
best solution is here though. Maybe we could rename to KeysEqualMatcher or
something?

https://codereview.chromium.org/2343123002/diff/20001/src/base/hashmap.h#newc...
src/base/hashmap.h:165: new (p) Entry(key, Value(), hash);
Could you add a comment that this is in-placement new and doesn't allocate
memory (so shouldn't be freed).

[Leszek Swirski, 2016-09-19 10:45:33]

https://codereview.chromium.org/2343123002/diff/20001/src/base/hashmap.h
File src/base/hashmap.h (right):

https://codereview.chromium.org/2343123002/diff/20001/src/base/hashmap.h#newc...
src/base/hashmap.h:92: static bool PointersMatch(typename
MatchFunHelper<Key>::KeyRef key1,
On 2016/09/19 10:32:07, rmcilroy wrote:
> Hmm, this isn't really PointersMatch unless Key is a pointer. Not sure what
the
> best solution is here though. Maybe we could rename to KeysEqualMatcher or
> something? 

Added a TODO because I want to move the matcher function to a template
parameter, and I'd rather send out code reviews for the usages once that's done.

https://codereview.chromium.org/2343123002/diff/20001/src/base/hashmap.h#newc...
src/base/hashmap.h:165: new (p) Entry(key, Value(), hash);
On 2016/09/19 10:32:07, rmcilroy wrote:
> Could you add a comment that this is in-placement new and doesn't allocate
> memory (so shouldn't be freed).

Done.

[Leszek Swirski, 2016-09-19 16:11:33]

The CQ bit was checked by leszeks@chromium.org

[Leszek Swirski, 2016-09-19 16:11:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2343123002/#ps40001
(title: "Add some clarifying comments")

[commit-bot: I haz the power, 2016-09-19 16:11:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 16:19:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 16:19:48]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/24369)

[Leszek Swirski, 2016-09-20 08:05:38]

The CQ bit was checked by leszeks@chromium.org

[Leszek Swirski, 2016-09-20 08:05:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2343123002/#ps60001
(title: "Update gyp/gn build files")

[commit-bot: I haz the power, 2016-09-20 08:05:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 08:40:11]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-20 08:40:42]

Description was changed from

==========
[base] Template hashmap on key and value

Adds template parameters for the TemplateHashMapImpl for the key and
value type, to allow them to be something other than pointers. To keep
the impact of this patch low, uses of TemplateHashMapImpl set these
types to void* to emulate the previous behaviour.

This is part of a wider set of changes discussed in:
https://groups.google.com/forum/#!topic/v8-dev/QLsC0XPYLeM
==========

to

==========
[base] Template hashmap on key and value

Adds template parameters for the TemplateHashMapImpl for the key and
value type, to allow them to be something other than pointers. To keep
the impact of this patch low, uses of TemplateHashMapImpl set these
types to void* to emulate the previous behaviour.

This is part of a wider set of changes discussed in:
https://groups.google.com/forum/#!topic/v8-dev/QLsC0XPYLeM

Committed: https://crrev.com/696dd65b80904ea9c029c3ce89d2a5307a1f69f6
Cr-Commit-Position: refs/heads/master@{#39530}
==========

[commit-bot: I haz the power, 2016-09-20 08:40:43]

Patchset 4 (id:??) landed as
https://crrev.com/696dd65b80904ea9c029c3ce89d2a5307a1f69f6
Cr-Commit-Position: refs/heads/master@{#39530}