Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: src/base/hashmap-entry.h

Issue 2343123002: [base] Template hashmap on key and value (Closed)
Patch Set: Update gyp/gn build files Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/base/hashmap.h ('k') | src/v8.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/base/hashmap-entry.h
diff --git a/src/base/hashmap-entry.h b/src/base/hashmap-entry.h
new file mode 100644
index 0000000000000000000000000000000000000000..629e734088f7451add5e4948ee729159af3ba83f
--- /dev/null
+++ b/src/base/hashmap-entry.h
@@ -0,0 +1,54 @@
+// Copyright 2016 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef V8_BASE_HASHMAP_ENTRY_H_
+#define V8_BASE_HASHMAP_ENTRY_H_
+
+#include <cstdint>
+
+namespace v8 {
+namespace base {
+
+// HashMap entries are (key, value, hash) triplets, with a boolean indicating if
+// they are an empty entry. Some clients may not need to use the value slot
+// (e.g. implementers of sets, where the key is the value).
+template <typename Key, typename Value>
+struct TemplateHashMapEntry {
+ Key key;
+ Value value;
+ uint32_t hash; // The full hash value for key
+
+ TemplateHashMapEntry(Key key, Value value, uint32_t hash)
+ : key(key), value(value), hash(hash), exists_(true) {}
+
+ bool exists() const { return exists_; }
+
+ void clear() { exists_ = false; }
+
+ private:
+ bool exists_;
+};
+
+// Specialization for pointer-valued keys
+template <typename Key, typename Value>
+struct TemplateHashMapEntry<Key*, Value> {
+ Key* key;
+ Value value;
+ uint32_t hash; // The full hash value for key
+
+ TemplateHashMapEntry(Key* key, Value value, uint32_t hash)
+ : key(key), value(value), hash(hash) {}
+
+ bool exists() const { return key != nullptr; }
+
+ void clear() { key = nullptr; }
+};
+
+// TODO(leszeks): There could be a specialisation for void values (e.g. for
+// sets), which omits the value field
+
+} // namespace base
+} // namespace v8
+
+#endif // V8_BASE_HASHMAP_ENTRY_H_
« no previous file with comments | « src/base/hashmap.h ('k') | src/v8.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698