Support ARIB STD B67, aka hybrid-log gamma (HLG) transfer function.

Support ARIB STD B67, aka hybrid-log gamma (HLG) transfer function.

BUG=645626
Committed: https://crrev.com/b51b4c09996725907fec2f9436d0c36cadd0d0c2
Cr-Commit-Position: refs/heads/master@{#419357}

[servolk, 2016-09-15 20:26:36]

The CQ bit was checked by servolk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 20:27:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[servolk, 2016-09-15 20:27:25]

Description was changed from

==========
Support ARIB STD B67, aka hybrid-log gamma (HLG) transfer function.

BUG=645626
==========

to

==========
Support ARIB STD B67, aka hybrid-log gamma (HLG) transfer function.

BUG=645626
==========

[servolk, 2016-09-15 20:27:25]

servolk@chromium.org changed reviewers:
+ danakj@chromium.org, hubbe@chromium.org, strobe@chromium.org

[hubbe, 2016-09-15 20:58:06]

https://codereview.chromium.org/2342963003/diff/1/ui/gfx/color_transform.cc
File ui/gfx/color_transform.cc (right):

https://codereview.chromium.org/2342963003/diff/1/ui/gfx/color_transform.cc#n...
ui/gfx/color_transform.cc:430: v_ = exp(v - c) / a + b;
Hmm, shouldn't this be exp((v - c) / a) + b ?

[servolk, 2016-09-15 21:12:14]

The CQ bit was checked by servolk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 21:12:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[servolk, 2016-09-15 21:12:50]

https://codereview.chromium.org/2342963003/diff/1/ui/gfx/color_transform.cc
File ui/gfx/color_transform.cc (right):

https://codereview.chromium.org/2342963003/diff/1/ui/gfx/color_transform.cc#n...
ui/gfx/color_transform.cc:430: v_ = exp(v - c) / a + b;
On 2016/09/15 20:58:06, hubbe wrote:
> Hmm, shouldn't this be exp((v - c) / a) + b ?

Ah, right, that was it, gfx_unittests pass now. Thanks!

[commit-bot: I haz the power, 2016-09-15 22:05:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 22:05:24]

Dry run: This issue passed the CQ dry run.

[hubbe, 2016-09-15 22:07:17]

lgtm

[servolk, 2016-09-15 22:19:05]

The CQ bit was checked by servolk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 22:19:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 23:25:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 23:25:52]

Dry run: This issue passed the CQ dry run.

[servolk, 2016-09-16 21:35:45]

On 2016/09/15 22:07:17, hubbe wrote:
> lgtm

Thanks!
Dana, could you please take a quick look too (since we need ui/gfx/OWNER
approval)?

[danakj, 2016-09-16 23:50:33]

RS LGTM

https://codereview.chromium.org/2342963003/diff/40001/ui/gfx/color_space.h
File ui/gfx/color_space.h (right):

https://codereview.chromium.org/2342963003/diff/40001/ui/gfx/color_space.h#ne...
ui/gfx/color_space.h:73: ARIB_STD_B67 = 18,  // AKA hybrid-log gamma, HLG
nit: comments need punctuation.

[servolk, 2016-09-16 23:54:27]

https://codereview.chromium.org/2342963003/diff/40001/ui/gfx/color_space.h
File ui/gfx/color_space.h (right):

https://codereview.chromium.org/2342963003/diff/40001/ui/gfx/color_space.h#ne...
ui/gfx/color_space.h:73: ARIB_STD_B67 = 18,  // AKA hybrid-log gamma, HLG
On 2016/09/16 23:50:33, danakj wrote:
> nit: comments need punctuation.

Thanks, I assume you mean just a dot at the end? I'll add that.

[servolk, 2016-09-16 23:55:58]

The CQ bit was checked by servolk@chromium.org

[servolk, 2016-09-16 23:55:59]

The patchset sent to the CQ was uploaded after l-g-t-m from hubbe@chromium.org,
danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2342963003/#ps60001
(title: "nit")

[commit-bot: I haz the power, 2016-09-16 23:56:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[servolk, 2016-09-16 23:56:49]

https://codereview.chromium.org/2342963003/diff/40001/ui/gfx/color_space.h
File ui/gfx/color_space.h (right):

https://codereview.chromium.org/2342963003/diff/40001/ui/gfx/color_space.h#ne...
ui/gfx/color_space.h:73: ARIB_STD_B67 = 18,  // AKA hybrid-log gamma, HLG
On 2016/09/16 23:54:27, servolk wrote:
> On 2016/09/16 23:50:33, danakj wrote:
> > nit: comments need punctuation.
> 
> Thanks, I assume you mean just a dot at the end? I'll add that.

Done.

[commit-bot: I haz the power, 2016-09-17 01:07:04]

Description was changed from

==========
Support ARIB STD B67, aka hybrid-log gamma (HLG) transfer function.

BUG=645626
==========

to

==========
Support ARIB STD B67, aka hybrid-log gamma (HLG) transfer function.

BUG=645626
==========

[commit-bot: I haz the power, 2016-09-17 01:07:06]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-17 01:10:54]

Description was changed from

==========
Support ARIB STD B67, aka hybrid-log gamma (HLG) transfer function.

BUG=645626
==========

to

==========
Support ARIB STD B67, aka hybrid-log gamma (HLG) transfer function.

BUG=645626

Committed: https://crrev.com/b51b4c09996725907fec2f9436d0c36cadd0d0c2
Cr-Commit-Position: refs/heads/master@{#419357}
==========

[commit-bot: I haz the power, 2016-09-17 01:10:55]

Patchset 4 (id:??) landed as
https://crrev.com/b51b4c09996725907fec2f9436d0c36cadd0d0c2
Cr-Commit-Position: refs/heads/master@{#419357}