Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Issue 2342963002: Pass ninja -n in the ninja -d explain step to avoid more work (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Pass ninja -n in the ninja -d explain step to avoid more work Suspect this is making it hard for me to debug why targets are being rebuilt, because they stabilize after two runs. BUG=646165 Committed: https://chromium.googlesource.com/chromium/tools/build/+/c65424c419105e0720cc0de09fb9e7a36c3d4601

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M scripts/slave/compile.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
agrieve
On 2016/09/15 20:03:17, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:dpranke@chromium.org
4 years, 3 months ago (2016-09-15 20:03:24 UTC) #3
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-15 20:05:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342963002/1
4 years, 3 months ago (2016-09-15 20:08:12 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 20:12:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/c65424c419105e0720cc...

Powered by Google App Engine
This is Rietveld 408576698