Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: scripts/slave/compile.py

Issue 2342963002: Pass ninja -n in the ninja -d explain step to avoid more work (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/compile.py
diff --git a/scripts/slave/compile.py b/scripts/slave/compile.py
index d601b9a511c9dee42610020f3bbc0b43c6538a24..2fde4d01acc028cfc780f2dbb82557c667dac725 100755
--- a/scripts/slave/compile.py
+++ b/scripts/slave/compile.py
@@ -432,7 +432,7 @@ def main_ninja(options, args, env):
# Run the build again if we want to check that the no-op build is clean.
filter_obj = EnsureUpToDateFilter()
# Append `-d explain` to help diagnose in the failure case.
- command += ['-d', 'explain']
+ command += ['-d', 'explain', '-n']
chromium_utils.RunCommand(command, env=env, filter_obj=filter_obj)
if not filter_obj.was_up_to_date:
print 'Failing build because ninja reported work to do.'
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698