third_party/WebKit/Source/modules/accessibility/AXProgressIndicator.cpp - Issue 2342913003: Replace narrowPrecisionToFloat with clampTo<float>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXProgressIndicator.cpp

Issue 2342913003: Replace narrowPrecisionToFloat with clampTo<float> (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp ('k') | third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXProgressIndicator.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXProgressIndicator.cpp b/third_party/WebKit/Source/modules/accessibility/AXProgressIndicator.cpp

index d133dfb4b0c007a4fccee7c3a81f9cfd16ebba4d..7e7fe7d0a6a5e26ae2c866e4c8a630bf345cb9e1 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXProgressIndicator.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXProgressIndicator.cpp

@@ -23,7 +23,7 @@

#include "core/html/HTMLProgressElement.h"

#include "core/layout/LayoutProgress.h"

#include "modules/accessibility/AXObjectCacheImpl.h"

-#include "platform/FloatConversion.h"

+#include "wtf/MathExtras.h"

namespace blink {

@@ -57,7 +57,7 @@ float AXProgressIndicator::valueForRange() const

return getAttribute(aria_valuenowAttr).toFloat();

if (element()->position() >= 0)

- return narrowPrecisionToFloat(element()->value());

+ return clampTo<float>(element()->value());

// Indeterminate progress bar should return 0.

return 0.0f;

}

@@ -67,7 +67,7 @@ float AXProgressIndicator::maxValueForRange() const

if (hasAttribute(aria_valuemaxAttr))

return getAttribute(aria_valuemaxAttr).toFloat();

- return narrowPrecisionToFloat(element()->max());

+ return clampTo<float>(element()->max());

}

float AXProgressIndicator::minValueForRange() const