Plugin Power Saver Tiny: Fix Field Trial testing config

Plugin Power Saver Tiny: Fix Field Trial testing config

Previously the field trial testing was incorrect. The key was the
feature name instead of the Finch experiment name.

BUG=608886
Committed: https://crrev.com/921187511a6fba333a6518857d697439505946d9
Cr-Commit-Position: refs/heads/master@{#419208}

[tommycli, 2016-09-15 20:24:46]

tommycli@chromium.org changed reviewers:
+ rkaplow@chromium.org

[tommycli, 2016-09-15 20:24:46]

rkaplow: PTAL

"PluginPowerSaverTiny" is the study name. "BlockSmallPluginContent" is the
Chrome feature name. I think we got them mixed up in the last go-around.

[tommycli, 2016-09-15 20:24:49]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 20:25:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 21:05:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 21:05:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rkaplow, 2016-09-15 21:14:04]

lgtm

ah sorry i missed it

[tommycli, 2016-09-15 21:18:08]

On 2016/09/15 21:14:04, rkaplow wrote:
> lgtm
> 
> ah sorry i missed it

no problem! to verify: the enable_features portion is required right? It doesn't
automagically pull that info from the g3 finch config?

[rkaplow, 2016-09-15 21:22:13]

lgtm

right

[tommycli, 2016-09-15 22:33:07]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 22:33:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-09-15 22:39:03]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 22:39:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-09-15 23:15:51]

rkaplow: Do you mind taking a second look? I updated some breaking tests from
the new config flags.

[commit-bot: I haz the power, 2016-09-15 23:39:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 23:39:11]

Dry run: This issue passed the CQ dry run.

[groby-ooo-7-16, 2016-09-16 17:39:46]

groby@chromium.org changed reviewers:
+ groby@chromium.org

[groby-ooo-7-16, 2016-09-16 17:39:47]

RS LGTM

[tommycli, 2016-09-16 17:40:14]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-09-16 17:40:15]

The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2342893003/#ps40001
(title: "Fix prerender tests")

[tommycli, 2016-09-16 17:40:25]

thanks all!

[commit-bot: I haz the power, 2016-09-16 17:40:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 17:47:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-16 17:51:13]

Description was changed from

==========
Plugin Power Saver Tiny: Fix Field Trial testing config

Previously the field trial testing was incorrect. The key was the
feature name instead of the Finch experiment name.

BUG=608886
==========

to

==========
Plugin Power Saver Tiny: Fix Field Trial testing config

Previously the field trial testing was incorrect. The key was the
feature name instead of the Finch experiment name.

BUG=608886

Committed: https://crrev.com/921187511a6fba333a6518857d697439505946d9
Cr-Commit-Position: refs/heads/master@{#419208}
==========

[commit-bot: I haz the power, 2016-09-16 17:51:15]

Patchset 3 (id:??) landed as
https://crrev.com/921187511a6fba333a6518857d697439505946d9
Cr-Commit-Position: refs/heads/master@{#419208}