Plugin Power Saver Tiny: Fix Field Trial testing config

chrome/browser/plugins/plugin_power_saver_browsertest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 #include <string>
 #include <utility>
 
 #include "base/command_line.h"
-#include "base/feature_list.h"
 #include "base/stl_util.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/stringprintf.h"
+#include "base/test/scoped_feature_list.h"
 #include "build/build_config.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_features.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/test_switches.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/zoom/zoom_controller.h"
@@ skipping 383 matching lines @@
 
 IN_PROC_BROWSER_TEST_F(PluginPowerSaverBrowserTest, EssentialPlugins) {
   LoadHTML(
       "<object id='small_same_origin' data='fake.swf' "
       "    type='application/x-ppapi-tests' width='400' height='100'>"
       "</object>"
       "<object id='small_same_origin_poster' data='fake.swf' "
       "    type='application/x-ppapi-tests' width='400' height='100' "
       "    poster='click_me.png'>"
       "</object>"
-      "<object id='tiny_cross_origin_1' data='http://a.com/fake.swf' "
-      "    type='application/x-ppapi-tests' width='3' height='3'>"
-      "</object>"
-      "<object id='tiny_cross_origin_2' data='http://a.com/fake.swf' "
-      "    type='application/x-ppapi-tests' width='1' height='1'>"
-      "</object>"
       "<object id='large_cross_origin' data='http://b.com/fake.swf' "
       "    type='application/x-ppapi-tests' width='400' height='500'>"
       "</object>"
       "<object id='medium_16_9_cross_origin' data='http://c.com/fake.swf' "
       "    type='application/x-ppapi-tests' width='480' height='270'>"
       "</object>");
 
   VerifyPluginMarkedEssential(GetActiveWebContents(), "small_same_origin");
   VerifyPluginMarkedEssential(GetActiveWebContents(),
                               "small_same_origin_poster");
-  VerifyPluginMarkedEssential(GetActiveWebContents(), "tiny_cross_origin_1");
-  VerifyPluginMarkedEssential(GetActiveWebContents(), "tiny_cross_origin_2");
   VerifyPluginMarkedEssential(GetActiveWebContents(), "large_cross_origin");
   VerifyPluginMarkedEssential(GetActiveWebContents(),
                               "medium_16_9_cross_origin");
 }
 
 // Flaky on WebKit Mac dbg bots: crbug.com/599484.
 #if defined(OS_MACOSX)
 #define MAYBE_SmallCrossOrigin DISABLED_SmallCrossOrigin
 #else
 #define MAYBE_SmallCrossOrigin SmallCrossOrigin
@@ skipping 215 matching lines @@
 IN_PROC_BROWSER_TEST_F(PluginPowerSaverBrowserTest, ZoomIndependent) {
   zoom::ZoomController::FromWebContents(GetActiveWebContents())
       ->SetZoomLevel(4.0);
   LoadHTML(
       "<object id='plugin' data='http://otherorigin.com/fake.swf' "
       "    type='application/x-ppapi-tests' width='400' height='200'>"
       "</object>");
   VerifyPluginIsThrottled(GetActiveWebContents(), "plugin");
 }
 
-// Separate test case that blocks tiny plugins. This requires a separate test
-// case, because we need to initialize the renderer with a different feature
-// setting.
-class PluginPowerSaverBlockTinyBrowserTest
-    : public PluginPowerSaverBrowserTest {
- public:
-  void SetUp() override {
-    base::FeatureList::ClearInstanceForTesting();
-    PluginPowerSaverBrowserTest::SetUp();
-  }
-  void SetUpInProcessBrowserTestFixture() override {
-    base::FeatureList::ClearInstanceForTesting();
-    std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);
-    feature_list->InitializeFromCommandLine(features::kBlockSmallContent.name,
-                                            std::string());
-    base::FeatureList::SetInstance(std::move(feature_list));
-  }
-};
-
-IN_PROC_BROWSER_TEST_F(PluginPowerSaverBlockTinyBrowserTest, BlockTinyPlugins) {
+IN_PROC_BROWSER_TEST_F(PluginPowerSaverBrowserTest, BlockTinyPlugins) {
   LoadHTML(
       "<object id='tiny_same_origin' data='fake.swf' "
       "    type='application/x-ppapi-tests' width='3' height='3'>"
       "</object>"
       "<object id='tiny_cross_origin_1' data='http://a.com/fake.swf' "
       "    type='application/x-ppapi-tests' width='3' height='3'>"
       "</object>"
       "<object id='tiny_cross_origin_2' data='http://a.com/fake.swf' "
       "    type='application/x-ppapi-tests' width='1' height='1'>"
       "</object>");
 
   VerifyPluginMarkedEssential(GetActiveWebContents(), "tiny_same_origin");
   VerifyPluginIsPlaceholderOnly("tiny_cross_origin_1");
   VerifyPluginIsPlaceholderOnly("tiny_cross_origin_2");
 }
 
-IN_PROC_BROWSER_TEST_F(PluginPowerSaverBlockTinyBrowserTest,
-                       BackgroundTabTinyPlugins) {
+IN_PROC_BROWSER_TEST_F(PluginPowerSaverBrowserTest, BackgroundTabTinyPlugins) {
   content::WebContents* background_contents = LoadHTMLInBackgroundTab(
       "<object id='tiny' data='http://a.com/fake.swf' "
       "    type='application/x-ppapi-tests' width='3' height='3'>"
       "</object>");
   EXPECT_FALSE(PluginLoaded(background_contents, "tiny"));
 
   ActivateTab(background_contents);
   VerifyPluginIsPlaceholderOnly("tiny");
 }
 
-IN_PROC_BROWSER_TEST_F(PluginPowerSaverBlockTinyBrowserTest,
-                       ExpandingTinyPlugins) {
+IN_PROC_BROWSER_TEST_F(PluginPowerSaverBrowserTest, ExpandingTinyPlugins) {
   LoadHTML(
       "<object id='expand_to_peripheral' data='http://a.com/fake.swf' "
       "    type='application/x-ppapi-tests' width='4' height='4'></object>"
       "<object id='expand_to_essential' data='http://b.com/fake.swf' "
       "    type='application/x-ppapi-tests' width='4' height='4'></object>");
 
   VerifyPluginIsPlaceholderOnly("expand_to_peripheral");
   VerifyPluginIsPlaceholderOnly("expand_to_essential");
 
   std::string script =
       "window.document.getElementById('expand_to_peripheral').height = 200;"
       "window.document.getElementById('expand_to_peripheral').width = 200;"
       "window.document.getElementById('expand_to_essential').height = 400;"
       "window.document.getElementById('expand_to_essential').width = 400;";
   ASSERT_TRUE(content::ExecuteScript(GetActiveWebContents(), script));
 
   VerifyPluginIsThrottled(GetActiveWebContents(), "expand_to_peripheral");
   VerifyPluginMarkedEssential(GetActiveWebContents(), "expand_to_essential");
 }
+
+// Separate test case that allows tiny plugins. This requires a separate test
+// case, because we need to initialize the renderer with a different feature
+// setting.
+class PluginPowerSaverAllowTinyBrowserTest
+    : public PluginPowerSaverBrowserTest {
+ public:
+  void SetUpInProcessBrowserTestFixture() override {
+    feature_list.InitAndDisableFeature(features::kBlockSmallContent);
+  }
+
+ private:
+  base::test::ScopedFeatureList feature_list;
+};
+
+IN_PROC_BROWSER_TEST_F(PluginPowerSaverAllowTinyBrowserTest,
+                       EssentialTinyPlugins) {
+  LoadHTML(
+      "<object id='tiny_cross_origin_1' data='http://a.com/fake.swf' "
+      "    type='application/x-ppapi-tests' width='3' height='3'>"
+      "</object>"
+      "<object id='tiny_cross_origin_2' data='http://a.com/fake.swf' "
+      "    type='application/x-ppapi-tests' width='1' height='1'>"
+      "</object>");
+
+  VerifyPluginMarkedEssential(GetActiveWebContents(), "tiny_cross_origin_1");
+  VerifyPluginMarkedEssential(GetActiveWebContents(), "tiny_cross_origin_2");
+}