Issue 2342803003: [Offline Pages] Gates immediate triggering (non scheduled) of background

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2342803003: [Offline Pages] Gates immediate triggering (non scheduled) of background (Closed)

Created:
4 years, 3 months ago by Pete Williamson

Modified:
4 years, 3 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

[Offline Pages] Gates immediate triggering (non scheduled) of background loading by whether low end device. Makes unit tests conditional on this check - ran unit tests on both svelte and regular devices locally. BUG=646888 Review-Url: https://codereview.chromium.org/2338313002 Cr-Commit-Position: refs/heads/master@{#418622} (cherry picked from commit 5bbcafffea9aea16942ca3a0c0e5c38473b4afa8) Committed: https://chromium.googlesource.com/chromium/src/+/7e4886b51a6fd5258d2c6f750d4537141c3588f3

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -4 lines)			Patch
	M	components/offline_pages/background/request_coordinator.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
	M	components/offline_pages/background/request_coordinator_unittest.cc	View		4 chunks	+21 lines, -4 lines	0 comments	Download

Total messages: 2 (1 generated)

Pete Williamson

4 years, 3 months ago (2016-09-15 23:12:48 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7e4886b51a6fd5258d2c6f750d4537141c3588f3.