Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2338313002: [Offline Pages] Gates immediate triggering (non scheduled) of background loading by whether low end… (Closed)

Created:
4 years, 3 months ago by dougarnett
Modified:
4 years, 3 months ago
Reviewers:
Pete Williamson
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Gates immediate triggering (non scheduled) of background loading by whether low end device. Makes unit tests conditional on this check - ran unit tests on both svelte and regular devices locally. BUG=646888 Committed: https://crrev.com/5bbcafffea9aea16942ca3a0c0e5c38473b4afa8 Cr-Commit-Position: refs/heads/master@{#418622}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M components/offline_pages/background/request_coordinator.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/offline_pages/background/request_coordinator_unittest.cc View 4 chunks +21 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dougarnett
4 years, 3 months ago (2016-09-14 16:37:48 UTC) #4
Pete Williamson
lgtm
4 years, 3 months ago (2016-09-14 18:22:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338313002/1
4 years, 3 months ago (2016-09-14 18:39:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 18:45:44 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 18:49:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5bbcafffea9aea16942ca3a0c0e5c38473b4afa8
Cr-Commit-Position: refs/heads/master@{#418622}

Powered by Google App Engine
This is Rietveld 408576698