Removed experimental app list flags. Experimental is now the only way.

Removed experimental app list flags. Experimental is now the only way.

Removed --enable/disable-experimental-app-list and
--enable-centered-app-list flags. Now always behaves as if experimental
(which was the default). This effectively removes the old
lower-left-corner tall app launcher (although all the code is still
there; it will be removed in a follow-up CL).

This cleans up the tests that set those switches, and removes tests that
test the old app launcher behaviour.

BUG=531059
Committed: https://crrev.com/7eb600a090209397874807d08afa0d629ca5d89d
Cr-Commit-Position: refs/heads/master@{#419405}

[Matt Giuca, 2016-09-16 02:24:38]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 02:24:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Matt Giuca, 2016-09-16 02:24:56]

mgiuca@chromium.org changed reviewers:
+ calamity@chromium.org

[commit-bot: I haz the power, 2016-09-16 03:32:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 03:32:18]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[calamity, 2016-09-16 04:30:40]

lgtm

[Matt Giuca, 2016-09-16 05:08:33]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 05:08:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 06:40:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 06:40:07]

Dry run: This issue passed the CQ dry run.

[Matt Giuca, 2016-09-16 06:55:06]

mgiuca@chromium.org changed reviewers:
+ jamescook@chromium.org, piman@chromium.org, tapted@chromium.org

[Matt Giuca, 2016-09-16 06:55:06]

piman@chromium.org: Please review changes in
chrome/browser/chromeos/login/chrome_restart_request.cc
tapted@chromium.org: Please review changes in
chrome/browser/apps/custom_launcher_page_browsertest_views.cc
jamescook@chromium.org: Please review changes in
ash/app_list/app_list_presenter_delegate_unittest.cc

Thanks!

[tapted, 2016-09-16 06:56:39]

On 2016/09/16 06:55:06, Matt Giuca wrote:
> mailto:tapted@chromium.org: Please review changes in
> chrome/browser/apps/custom_launcher_page_browsertest_views.cc

chrome/browser/apps/custom_launcher_page_browsertest_views.cc lgtm

[James Cook, 2016-09-16 15:48:17]

ash LGTM with nit

https://codereview.chromium.org/2342773002/diff/60001/ash/app_list/app_list_p...
File ash/app_list/app_list_presenter_delegate_unittest.cc (right):

https://codereview.chromium.org/2342773002/diff/60001/ash/app_list/app_list_p...
ash/app_list/app_list_presenter_delegate_unittest.cc:47: // Make the display big
enough to hold the experimental app list.
nit: remove "experimental"

https://codereview.chromium.org/2342773002/diff/60001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (left):

https://codereview.chromium.org/2342773002/diff/60001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:1387: #if defined(ENABLE_APP_LIST)
Question (out of curiosity, not requesting anything): Will this macro be going
away as well?

[piman, 2016-09-16 16:53:00]

lgtm

[Matt Giuca, 2016-09-19 00:19:57]

https://codereview.chromium.org/2342773002/diff/60001/ash/app_list/app_list_p...
File ash/app_list/app_list_presenter_delegate_unittest.cc (right):

https://codereview.chromium.org/2342773002/diff/60001/ash/app_list/app_list_p...
ash/app_list/app_list_presenter_delegate_unittest.cc:47: // Make the display big
enough to hold the experimental app list.
On 2016/09/16 15:48:17, James Cook wrote:
> nit: remove "experimental"

Done.

https://codereview.chromium.org/2342773002/diff/60001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (left):

https://codereview.chromium.org/2342773002/diff/60001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:1387: #if defined(ENABLE_APP_LIST)
On 2016/09/16 15:48:17, James Cook wrote:
> Question (out of curiosity, not requesting anything): Will this macro be going
> away as well?

Well, we could since the app list is pretty firmly part of Chrome OS now and it
doesn't really make sense to remove it. But I wasn't planning to remove this
flag and it still "works" for the most part (if you turn off the flag, the
launcher button just disappears).

[Matt Giuca, 2016-09-19 00:20:02]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2016-09-19 00:20:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org, tapted@chromium.org, jamescook@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2342773002/#ps80001
(title: "Respond to nit.")

[commit-bot: I haz the power, 2016-09-19 00:20:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 01:17:51]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-19 01:19:35]

Description was changed from

==========
Removed experimental app list flags. Experimental is now the only way.

Removed --enable/disable-experimental-app-list and
--enable-centered-app-list flags. Now always behaves as if experimental
(which was the default). This effectively removes the old
lower-left-corner tall app launcher (although all the code is still
there; it will be removed in a follow-up CL).

This cleans up the tests that set those switches, and removes tests that
test the old app launcher behaviour.

BUG=531059
==========

to

==========
Removed experimental app list flags. Experimental is now the only way.

Removed --enable/disable-experimental-app-list and
--enable-centered-app-list flags. Now always behaves as if experimental
(which was the default). This effectively removes the old
lower-left-corner tall app launcher (although all the code is still
there; it will be removed in a follow-up CL).

This cleans up the tests that set those switches, and removes tests that
test the old app launcher behaviour.

BUG=531059

Committed: https://crrev.com/7eb600a090209397874807d08afa0d629ca5d89d
Cr-Commit-Position: refs/heads/master@{#419405}
==========

[commit-bot: I haz the power, 2016-09-19 01:19:37]

Patchset 5 (id:??) landed as
https://crrev.com/7eb600a090209397874807d08afa0d629ca5d89d
Cr-Commit-Position: refs/heads/master@{#419405}