Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2341113003: Remove deprecation warning banner from App Launcher code. (Closed)

Created:
4 years, 3 months ago by Matt Giuca
Modified:
4 years, 3 months ago
Reviewers:
tapted
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove deprecation warning banner from App Launcher code. Should have no visible effect (since the banner wasn't visible on CrOS). This reverts commit 192a6f001ffe62cca3b685fcd7ca5e43b7896695. This reverts commit c00f1d07c1aca9fcfddbc40ed1057425cac020fc. BUG=576531 Committed: https://crrev.com/4aa80a4b38b4325c97e53618fe18e3f0673135e6 Cr-Commit-Position: refs/heads/master@{#419111}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -297 lines) Patch
M chrome/app/chromium_strings.grd View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.h View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 2 chunks +0 lines, -43 lines 0 comments Download
M ui/app_list/app_list_constants.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/app_list/app_list_view_delegate.h View 1 chunk +0 lines, -15 lines 0 comments Download
M ui/app_list/app_list_view_delegate.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M ui/app_list/views/app_list_view_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/app_list/views/apps_container_view.h View 4 chunks +1 line, -14 lines 0 comments Download
M ui/app_list/views/apps_container_view.cc View 6 chunks +2 lines, -158 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
Matt Giuca
4 years, 3 months ago (2016-09-16 05:05:30 UTC) #3
tapted
lgtm for a second I was "what about Mac" but then I realised.. Unlrelated: just ...
4 years, 3 months ago (2016-09-16 06:12:17 UTC) #5
Matt Giuca
On 2016/09/16 06:12:17, tapted wrote: > lgtm > > for a second I was "what ...
4 years, 3 months ago (2016-09-16 06:30:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341113003/1
4 years, 3 months ago (2016-09-16 06:30:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 06:35:24 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 06:37:35 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4aa80a4b38b4325c97e53618fe18e3f0673135e6
Cr-Commit-Position: refs/heads/master@{#419111}

Powered by Google App Engine
This is Rietveld 408576698