Reland: Update image and text color when row is selected in the chooser on Mac

Update image and text color when row is selected in the chooser on Mac

This CL added code to change the image and text color in the chooser row
when it is selected so that it is more visible.

1. changed text from black to white when row is selected.
2. changed image from black to white when row is selected.
3. changed "Paired" text color to use gfx::kGoogleGreen300 when row is selected.

I uploaded screenshots to the issue page.

BUG=645693
Committed: https://crrev.com/188a5ae80ab8cca65c8c987a5bfb8a37e33a773e
Committed: https://crrev.com/310655348f28d0b2135ff8eff52ba1945782587c
Cr-Original-Commit-Position: refs/heads/master@{#421606}
Cr-Commit-Position: refs/heads/master@{#421752}

[juncai, 2016-09-14 23:48:24]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 23:49:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-09-15 00:58:52]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 00:59:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 04:43:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 04:43:15]

Dry run: This issue passed the CQ dry run.

[juncai, 2016-09-15 20:23:53]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 20:24:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-09-15 20:24:52]

Description was changed from

==========
Update image and text color when row is selected in the chooser on Mac

This CL added code to change the image and text color in the chooser row
when it is selected so that it is more visible.

1. changed text from black to white when row is selected.
2. changed image from black to white when row is selected.
3. changed "Paired" text color to a more visible green when row is selected.

I uploaded screenshots to the issue page.

BUG=645693
==========

to

==========
Update image and text color when row is selected in the chooser on Mac

This CL added code to change the image and text color in the chooser row
when it is selected so that it is more visible.

1. changed text from black to white when row is selected.
2. changed image from black to white when row is selected.
3. changed "Paired" text color to use Google Green 300 when row is selected.

I uploaded screenshots to the issue page.

BUG=645693
==========

[juncai, 2016-09-15 20:25:20]

Description was changed from

==========
Update image and text color when row is selected in the chooser on Mac

This CL added code to change the image and text color in the chooser row
when it is selected so that it is more visible.

1. changed text from black to white when row is selected.
2. changed image from black to white when row is selected.
3. changed "Paired" text color to use Google Green 300 when row is selected.

I uploaded screenshots to the issue page.

BUG=645693
==========

to

==========
Update image and text color when row is selected in the chooser on Mac

This CL added code to change the image and text color in the chooser row
when it is selected so that it is more visible.

1. changed text from black to white when row is selected.
2. changed image from black to white when row is selected.
3. changed "Paired" text color to use gfx::kGoogleGreen300 when row is selected.

I uploaded screenshots to the issue page.

BUG=645693
==========

[juncai, 2016-09-15 20:29:21]

juncai@chromium.org changed reviewers:
+ jyasskin@chromium.org, msw@chromium.org, oshima@chromium.org,
rsesek@chromium.org

[juncai, 2016-09-15 20:29:22]

oshima@chromium.org: Please review changes in 
//ui/resources/

msw@chromium.org: Please review changes in 
//chrome/browser/ui/views/

rsesek@chromium.org: Please review changes in 
//chrome/browser/ui/cocoa/

jyasskin@chromium.org: Please review changes in 
//chrome/browser/chooser_controller/

[msw, 2016-09-15 21:14:56]

c/b/ui/views/ lgtm, but be careful to respect native theme colors if you attempt
something similar for views (picking black/white text/icons based on selection
state may not work well if eg. linux users customize the background/selection
colors, or win users invert colors for accessibility)

[commit-bot: I haz the power, 2016-09-15 21:21:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 21:21:30]

Dry run: This issue passed the CQ dry run.

[juncai, 2016-09-15 22:15:08]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 22:15:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Robert Sesek, 2016-09-15 22:24:18]

LGTM

[commit-bot: I haz the power, 2016-09-15 23:17:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 23:17:07]

Dry run: This issue passed the CQ dry run.

[juncai, 2016-09-21 16:41:04]

juncai@chromium.org changed reviewers:
+ sky@chromium.org

[juncai, 2016-09-21 16:41:04]

Since oshima@ is OOO, added sky@ as the reviewer.

[sky, 2016-09-21 17:41:20]

https://codereview.chromium.org/2342723002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/chooser_content_view.cc (right):

https://codereview.chromium.org/2342723002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/chooser_content_view.cc:31: const int
kSignalStrengthLevelBlackImageIds[5] = {
Is there a reason views doesn't change color like mac?

Also, did you consider leaving the ones you named as black as they were before
and instead of white using selected? So, you would have IDR_SIGNAL_0_BAR and
IDR_SIGNAL_0_BAR_SELECTED. It seems clearer that way as the names black and
white don't convey their expected usage.

[juncai, 2016-09-21 19:39:56]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 19:40:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-09-21 19:51:24]

Ran tools/resources/optimize-png-files.sh for all the signal strength level
related png files.

https://codereview.chromium.org/2342723002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/chooser_content_view.cc (right):

https://codereview.chromium.org/2342723002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/chooser_content_view.cc:31: const int
kSignalStrengthLevelBlackImageIds[5] = {
On 2016/09/21 17:41:19, sky wrote:
> Is there a reason views doesn't change color like mac?
The row in the chooser on Mac is a NSView:
https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/website_settings...
And it doesn't automatically change its color when selected.

> Also, did you consider leaving the ones you named as black as they were before
> and instead of white using selected? So, you would have IDR_SIGNAL_0_BAR and
> IDR_SIGNAL_0_BAR_SELECTED. It seems clearer that way as the names black and
> white don't convey their expected usage.
Done.

[commit-bot: I haz the power, 2016-09-21 20:29:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 20:29:05]

Dry run: This issue passed the CQ dry run.

[sky, 2016-09-21 21:53:24]

LGTM

[juncai, 2016-09-26 16:38:35]

ping jyasskin@.

[Jeffrey Yasskin, 2016-09-26 22:25:47]

On 2016/09/15 21:14:56, msw wrote:
> c/b/ui/views/ lgtm, but be careful to respect native theme colors if you
attempt
> something similar for views (picking black/white text/icons based on selection
> state may not work well if eg. linux users customize the background/selection
> colors, or win users invert colors for accessibility)

Does Mac allow users to change the selection color? If it does, this CL is a
problem too.

https://codereview.chromium.org/2342723002/diff/80001/chrome/browser/chooser_...
File chrome/browser/chooser_controller/mock_chooser_controller.h (right):

https://codereview.chromium.org/2342723002/diff/80001/chrome/browser/chooser_...
chrome/browser/chooser_controller/mock_chooser_controller.h:61: static const int
kImageColorBlack;
Since the images changed names from black/white to <nothing>/selected, maybe
call these kImageColorUnselected and kImageColorSelected.

https://codereview.chromium.org/2342723002/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/chooser_content_view_cocoa.h (right):

https://codereview.chromium.org/2342723002/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/chooser_content_view_cocoa.h:161: // Gets the image from
table row view.
Would it make sense to say "For testing and internal use only." here? I don't
think we want to make these part of the production interface, even if
updateContentRowColor has to use them.

https://codereview.chromium.org/2342723002/diff/80001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm
(right):

https://codereview.chromium.org/2342723002/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm:492:
// Select option 1.
In these comments, say why you're doing the operation, not just what operation
you're doing. Is this here to test that there's no special case for the 0th
option?

https://codereview.chromium.org/2342723002/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm:525:
// Select option 0.
You already tested that selecting option 0 has the expected effect, so it's not
clear what this repetition adds. Say what it's for in the comment, or if there's
no particular code or potential behavior that it's checking for, you should omit
it.

[juncai, 2016-09-27 22:01:53]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 22:02:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-09-27 22:10:48]

https://codereview.chromium.org/2342723002/diff/80001/chrome/browser/chooser_...
File chrome/browser/chooser_controller/mock_chooser_controller.h (right):

https://codereview.chromium.org/2342723002/diff/80001/chrome/browser/chooser_...
chrome/browser/chooser_controller/mock_chooser_controller.h:61: static const int
kImageColorBlack;
On 2016/09/26 22:25:46, Jeffrey Yasskin wrote:
> Since the images changed names from black/white to <nothing>/selected, maybe
> call these kImageColorUnselected and kImageColorSelected.

Done.

https://codereview.chromium.org/2342723002/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/chooser_content_view_cocoa.h (right):

https://codereview.chromium.org/2342723002/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/chooser_content_view_cocoa.h:161: // Gets the image from
table row view.
On 2016/09/26 22:25:46, Jeffrey Yasskin wrote:
> Would it make sense to say "For testing and internal use only." here? I don't
> think we want to make these part of the production interface, even if
> updateContentRowColor has to use them.

Done.

https://codereview.chromium.org/2342723002/diff/80001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm
(right):

https://codereview.chromium.org/2342723002/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm:492:
// Select option 1.
On 2016/09/26 22:25:46, Jeffrey Yasskin wrote:
> In these comments, say why you're doing the operation, not just what operation
> you're doing. Is this here to test that there's no special case for the 0th
> option?

Since option 0 shows a Bluetooth connected image and option 1 and 2 show a
signal strength level image, need to test in both cases the image color changes
when selected/deselected.

I added comments to clarify it.

Done.

https://codereview.chromium.org/2342723002/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm:525:
// Select option 0.
On 2016/09/26 22:25:46, Jeffrey Yasskin wrote:
> You already tested that selecting option 0 has the expected effect, so it's
not
> clear what this repetition adds. Say what it's for in the comment, or if
there's
> no particular code or potential behavior that it's checking for, you should
omit
> it.

Done.

[juncai, 2016-09-27 22:13:24]

On 2016/09/26 22:25:47, Jeffrey Yasskin wrote:
> On 2016/09/15 21:14:56, msw wrote:
> > c/b/ui/views/ lgtm, but be careful to respect native theme colors if you
> attempt
> > something similar for views (picking black/white text/icons based on
selection
> > state may not work well if eg. linux users customize the
background/selection
> > colors, or win users invert colors for accessibility)
> 
> Does Mac allow users to change the selection color? If it does, this CL is a
> problem too.

Yes, Mac allows users to change the selection color. But we can not predict what
user will do. For example, website usually shows text using black color, and if
a user changes the selection color to be black too, and when selecting some
text, it will be hard to read it. But the browser won't change the text color
according to the selection color. Based on this, we can choose not to change the
image and text color in the chooser when a row is selected. This is one option.
However, I think changing the selected color to be white seems a safe choice and
it works in most circumstances (except when user changes the selection color to
be white, but we can not predict it). So I think this CL is still worth to do
and it can improve user experience when using the chooser.

[Jeffrey Yasskin, 2016-09-27 22:24:07]

On 2016/09/27 22:13:24, juncai wrote:
> On 2016/09/26 22:25:47, Jeffrey Yasskin wrote:
> > On 2016/09/15 21:14:56, msw wrote:
> > > c/b/ui/views/ lgtm, but be careful to respect native theme colors if you
> > attempt
> > > something similar for views (picking black/white text/icons based on
> selection
> > > state may not work well if eg. linux users customize the
> background/selection
> > > colors, or win users invert colors for accessibility)
> > 
> > Does Mac allow users to change the selection color? If it does, this CL is a
> > problem too.
> 
> Yes, Mac allows users to change the selection color. But we can not predict
what
> user will do. For example, website usually shows text using black color, and
if
> a user changes the selection color to be black too, and when selecting some
> text, it will be hard to read it. But the browser won't change the text color
> according to the selection color. Based on this, we can choose not to change
the
> image and text color in the chooser when a row is selected. This is one
option.
> However, I think changing the selected color to be white seems a safe choice
and
> it works in most circumstances (except when user changes the selection color
to
> be white, but we can not predict it). So I think this CL is still worth to do
> and it can improve user experience when using the chooser.

It looks like Mac's easily-accessible option is to invert colors, and that looks
like it'll invert the icon colors at the same time, instead of inverting our
selection colors while leaving the icons alone.

LGTM

https://codereview.chromium.org/2342723002/diff/100001/chrome/browser/ui/coco...
File
chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm
(right):

https://codereview.chromium.org/2342723002/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm:532:
// selecting another option.
"... selecting another option without deselecting the first."

https://codereview.chromium.org/2342723002/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm:554:
// Select option 2.
Does this test add any coverage over the "Select option 1" section?

https://codereview.chromium.org/2342723002/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm:585:
// Update option 2 again.
What's this second update checking that the first didn't? (I think it's that you
can go from not-paired to paired, while the previous test checked going from one
signal strength to another.)

[commit-bot: I haz the power, 2016-09-27 22:52:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 22:52:30]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-09-28 00:07:30]

ui/resources lgtm

optional: for simple assets like this, please consider using vector icons.

[juncai, 2016-09-28 17:35:26]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 17:36:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-09-28 17:42:27]

On 2016/09/28 00:07:30, oshima wrote:
> ui/resources lgtm
> 
> optional: for simple assets like this, please consider using vector icons.

We discussed this at:
https://codereview.chromium.org/2304213002/
And estade@ mentioned that for signal strength there is code to draw directly
instead of using .icon files or .png files, and I think the code now is for
ChromeOS only, and he is working on making it public to all platforms. Since we
already have used .png for signal strength and eventually will use code to draw
the signal strength icon directly, I filed a bug to track that:
https://bugs.chromium.org/p/chromium/issues/detail?id=645669

[juncai, 2016-09-28 17:44:40]

https://codereview.chromium.org/2342723002/diff/100001/chrome/browser/ui/coco...
File
chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm
(right):

https://codereview.chromium.org/2342723002/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm:532:
// selecting another option.
On 2016/09/27 22:24:07, Jeffrey Yasskin wrote:
> "... selecting another option without deselecting the first."

Done.

https://codereview.chromium.org/2342723002/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm:554:
// Select option 2.
On 2016/09/27 22:24:06, Jeffrey Yasskin wrote:
> Does this test add any coverage over the "Select option 1" section?

Almost the same except it uses a different strength level image. So I removed
it.

Done.

https://codereview.chromium.org/2342723002/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm:585:
// Update option 2 again.
On 2016/09/27 22:24:06, Jeffrey Yasskin wrote:
> What's this second update checking that the first didn't? (I think it's that
you
> can go from not-paired to paired, while the previous test checked going from
one
> signal strength to another.)

Yes, I added comments here.

Done.

[commit-bot: I haz the power, 2016-09-28 18:31:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 18:31:15]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[juncai, 2016-09-28 18:40:35]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 18:40:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 19:27:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 19:27:35]

Dry run: This issue passed the CQ dry run.

[juncai, 2016-09-28 19:30:09]

The CQ bit was checked by juncai@chromium.org

[juncai, 2016-09-28 19:30:10]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
rsesek@chromium.org, sky@chromium.org, oshima@chromium.org,
jyasskin@chromium.org
Link to the patchset: https://codereview.chromium.org/2342723002/#ps140001
(title: "fix Mac test")

[commit-bot: I haz the power, 2016-09-28 19:30:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 19:36:47]

Description was changed from

==========
Update image and text color when row is selected in the chooser on Mac

This CL added code to change the image and text color in the chooser row
when it is selected so that it is more visible.

1. changed text from black to white when row is selected.
2. changed image from black to white when row is selected.
3. changed "Paired" text color to use gfx::kGoogleGreen300 when row is selected.

I uploaded screenshots to the issue page.

BUG=645693
==========

to

==========
Update image and text color when row is selected in the chooser on Mac

This CL added code to change the image and text color in the chooser row
when it is selected so that it is more visible.

1. changed text from black to white when row is selected.
2. changed image from black to white when row is selected.
3. changed "Paired" text color to use gfx::kGoogleGreen300 when row is selected.

I uploaded screenshots to the issue page.

BUG=645693
==========

[commit-bot: I haz the power, 2016-09-28 19:36:49]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-09-28 19:39:28]

Description was changed from

==========
Update image and text color when row is selected in the chooser on Mac

This CL added code to change the image and text color in the chooser row
when it is selected so that it is more visible.

1. changed text from black to white when row is selected.
2. changed image from black to white when row is selected.
3. changed "Paired" text color to use gfx::kGoogleGreen300 when row is selected.

I uploaded screenshots to the issue page.

BUG=645693
==========

to

==========
Update image and text color when row is selected in the chooser on Mac

This CL added code to change the image and text color in the chooser row
when it is selected so that it is more visible.

1. changed text from black to white when row is selected.
2. changed image from black to white when row is selected.
3. changed "Paired" text color to use gfx::kGoogleGreen300 when row is selected.

I uploaded screenshots to the issue page.

BUG=645693

Committed: https://crrev.com/188a5ae80ab8cca65c8c987a5bfb8a37e33a773e
Cr-Commit-Position: refs/heads/master@{#421606}
==========

[commit-bot: I haz the power, 2016-09-28 19:39:30]

Patchset 8 (id:??) landed as
https://crrev.com/188a5ae80ab8cca65c8c987a5bfb8a37e33a773e
Cr-Commit-Position: refs/heads/master@{#421606}

[juncai, 2016-09-28 22:13:39]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/2380903002/ by juncai@chromium.org.

The reason for reverting is:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%20....

[juncai, 2016-09-28 22:30:15]

Description was changed from

==========
Update image and text color when row is selected in the chooser on Mac

This CL added code to change the image and text color in the chooser row
when it is selected so that it is more visible.

1. changed text from black to white when row is selected.
2. changed image from black to white when row is selected.
3. changed "Paired" text color to use gfx::kGoogleGreen300 when row is selected.

I uploaded screenshots to the issue page.

BUG=645693

Committed: https://crrev.com/188a5ae80ab8cca65c8c987a5bfb8a37e33a773e
Cr-Commit-Position: refs/heads/master@{#421606}
==========

to

==========
Update image and text color when row is selected in the chooser on Mac

This CL added code to change the image and text color in the chooser row
when it is selected so that it is more visible.

1. changed text from black to white when row is selected.
2. changed image from black to white when row is selected.
3. changed "Paired" text color to use gfx::kGoogleGreen300 when row is selected.

I uploaded screenshots to the issue page.

BUG=645693

Committed: https://crrev.com/188a5ae80ab8cca65c8c987a5bfb8a37e33a773e
Cr-Commit-Position: refs/heads/master@{#421606}
==========

[juncai, 2016-09-28 23:48:01]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 23:48:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 00:53:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 00:53:30]

Dry run: This issue passed the CQ dry run.

[juncai, 2016-09-29 05:08:07]

The CQ bit was checked by juncai@chromium.org

[juncai, 2016-09-29 05:08:08]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
msw@chromium.org, oshima@chromium.org, sky@chromium.org, jyasskin@chromium.org
Link to the patchset: https://codereview.chromium.org/2342723002/#ps160001
(title: "fixed Mac asan test")

[commit-bot: I haz the power, 2016-09-29 05:08:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 05:14:47]

Description was changed from

==========
Update image and text color when row is selected in the chooser on Mac

This CL added code to change the image and text color in the chooser row
when it is selected so that it is more visible.

1. changed text from black to white when row is selected.
2. changed image from black to white when row is selected.
3. changed "Paired" text color to use gfx::kGoogleGreen300 when row is selected.

I uploaded screenshots to the issue page.

BUG=645693

Committed: https://crrev.com/188a5ae80ab8cca65c8c987a5bfb8a37e33a773e
Cr-Commit-Position: refs/heads/master@{#421606}
==========

to

==========
Update image and text color when row is selected in the chooser on Mac

This CL added code to change the image and text color in the chooser row
when it is selected so that it is more visible.

1. changed text from black to white when row is selected.
2. changed image from black to white when row is selected.
3. changed "Paired" text color to use gfx::kGoogleGreen300 when row is selected.

I uploaded screenshots to the issue page.

BUG=645693

Committed: https://crrev.com/188a5ae80ab8cca65c8c987a5bfb8a37e33a773e
Cr-Commit-Position: refs/heads/master@{#421606}
==========

[commit-bot: I haz the power, 2016-09-29 05:14:48]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-09-29 05:17:57]

Description was changed from

==========
Update image and text color when row is selected in the chooser on Mac

This CL added code to change the image and text color in the chooser row
when it is selected so that it is more visible.

1. changed text from black to white when row is selected.
2. changed image from black to white when row is selected.
3. changed "Paired" text color to use gfx::kGoogleGreen300 when row is selected.

I uploaded screenshots to the issue page.

BUG=645693

Committed: https://crrev.com/188a5ae80ab8cca65c8c987a5bfb8a37e33a773e
Cr-Commit-Position: refs/heads/master@{#421606}
==========

to

==========
Update image and text color when row is selected in the chooser on Mac

This CL added code to change the image and text color in the chooser row
when it is selected so that it is more visible.

1. changed text from black to white when row is selected.
2. changed image from black to white when row is selected.
3. changed "Paired" text color to use gfx::kGoogleGreen300 when row is selected.

I uploaded screenshots to the issue page.

BUG=645693

Committed: https://crrev.com/188a5ae80ab8cca65c8c987a5bfb8a37e33a773e
Committed: https://crrev.com/310655348f28d0b2135ff8eff52ba1945782587c
Cr-Original-Commit-Position: refs/heads/master@{#421606}
Cr-Commit-Position: refs/heads/master@{#421752}
==========

[commit-bot: I haz the power, 2016-09-29 05:17:58]

Patchset 9 (id:??) landed as
https://crrev.com/310655348f28d0b2135ff8eff52ba1945782587c
Cr-Commit-Position: refs/heads/master@{#421752}