Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: net/quic/chromium/quic_chromium_client_session.cc

Issue 2342663003: QUIC - add UMA histogram to track retransmit rate for large uploads. (Closed)
Patch Set: add when value is recorded. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/quic_chromium_client_session.cc
diff --git a/net/quic/chromium/quic_chromium_client_session.cc b/net/quic/chromium/quic_chromium_client_session.cc
index 7f36db24a72a20b76f831c823da929af7ba6058d..f7a1c65131abda4e1533975f1128977aa73dedc2 100644
--- a/net/quic/chromium/quic_chromium_client_session.cc
+++ b/net/quic/chromium/quic_chromium_client_session.cc
@@ -371,6 +371,13 @@ QuicChromiumClientSession::~QuicChromiumClientSession() {
UMA_HISTOGRAM_COUNTS("Net.QuicSession.MtuProbesSent",
connection()->mtu_probe_count());
+ if (stats.packets_sent >= 100) {
+ // Used to monitor for regressions that effect large uploads.
+ UMA_HISTOGRAM_COUNTS_1000(
+ "Net.QuicSession.PacketRetransmitsPerMille",
+ 1000 * stats.packets_retransmitted / stats.packets_sent);
+ }
+
if (stats.max_sequence_reordering == 0)
return;
const base::HistogramBase::Sample kMaxReordering = 100;
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698