Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Side by Side Diff: net/quic/chromium/quic_chromium_client_session.cc

Issue 2342663003: QUIC - add UMA histogram to track retransmit rate for large uploads. (Closed)
Patch Set: add when value is recorded. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/chromium/quic_chromium_client_session.h" 5 #include "net/quic/chromium/quic_chromium_client_session.h"
6 6
7 #include <openssl/ssl.h> 7 #include <openssl/ssl.h>
8 8
9 #include <utility> 9 #include <utility>
10 10
(...skipping 353 matching lines...) Expand 10 before | Expand all | Expand 10 after
364 // (initial values and MTU discovery values), but does not fare well when 364 // (initial values and MTU discovery values), but does not fare well when
365 // bucketed. Because of that, a sparse histogram is used here. 365 // bucketed. Because of that, a sparse histogram is used here.
366 UMA_HISTOGRAM_SPARSE_SLOWLY("Net.QuicSession.ClientSideMtu", 366 UMA_HISTOGRAM_SPARSE_SLOWLY("Net.QuicSession.ClientSideMtu",
367 connection()->max_packet_length()); 367 connection()->max_packet_length());
368 UMA_HISTOGRAM_SPARSE_SLOWLY("Net.QuicSession.ServerSideMtu", 368 UMA_HISTOGRAM_SPARSE_SLOWLY("Net.QuicSession.ServerSideMtu",
369 stats.max_received_packet_size); 369 stats.max_received_packet_size);
370 370
371 UMA_HISTOGRAM_COUNTS("Net.QuicSession.MtuProbesSent", 371 UMA_HISTOGRAM_COUNTS("Net.QuicSession.MtuProbesSent",
372 connection()->mtu_probe_count()); 372 connection()->mtu_probe_count());
373 373
374 if (stats.packets_sent >= 100) {
375 // Used to monitor for regressions that effect large uploads.
376 UMA_HISTOGRAM_COUNTS_1000(
377 "Net.QuicSession.PacketRetransmitsPerMille",
378 1000 * stats.packets_retransmitted / stats.packets_sent);
379 }
380
374 if (stats.max_sequence_reordering == 0) 381 if (stats.max_sequence_reordering == 0)
375 return; 382 return;
376 const base::HistogramBase::Sample kMaxReordering = 100; 383 const base::HistogramBase::Sample kMaxReordering = 100;
377 base::HistogramBase::Sample reordering = kMaxReordering; 384 base::HistogramBase::Sample reordering = kMaxReordering;
378 if (stats.min_rtt_us > 0) { 385 if (stats.min_rtt_us > 0) {
379 reordering = static_cast<base::HistogramBase::Sample>( 386 reordering = static_cast<base::HistogramBase::Sample>(
380 100 * stats.max_time_reordering_us / stats.min_rtt_us); 387 100 * stats.max_time_reordering_us / stats.min_rtt_us);
381 } 388 }
382 UMA_HISTOGRAM_CUSTOM_COUNTS("Net.QuicSession.MaxReorderingTime", reordering, 389 UMA_HISTOGRAM_CUSTOM_COUNTS("Net.QuicSession.MaxReorderingTime", reordering,
383 1, kMaxReordering, 50); 390 1, kMaxReordering, 50);
(...skipping 1009 matching lines...) Expand 10 before | Expand all | Expand 10 after
1393 } 1400 }
1394 1401
1395 const LoadTimingInfo::ConnectTiming& 1402 const LoadTimingInfo::ConnectTiming&
1396 QuicChromiumClientSession::GetConnectTiming() { 1403 QuicChromiumClientSession::GetConnectTiming() {
1397 connect_timing_.ssl_start = connect_timing_.connect_start; 1404 connect_timing_.ssl_start = connect_timing_.connect_start;
1398 connect_timing_.ssl_end = connect_timing_.connect_end; 1405 connect_timing_.ssl_end = connect_timing_.connect_end;
1399 return connect_timing_; 1406 return connect_timing_;
1400 } 1407 }
1401 1408
1402 } // namespace net 1409 } // namespace net
OLDNEW
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698