Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2342663002: [css-flexbox] Fix size comparison when scrollbars are present (Closed)

Created:
4 years, 3 months ago by cbiesinger
Modified:
4 years, 3 months ago
Reviewers:
dgrogan, eae, cbiesinger1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-flexbox] Fix size comparison when scrollbars are present BUG=646288 Committed: https://crrev.com/4567d59b87472d29a1fc660a55cd8aa56c83f280 Cr-Commit-Position: refs/heads/master@{#418846}

Patch Set 1 #

Patch Set 2 : add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/css3/flexbox/bug646288.html View 1 1 chunk +31 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
cbiesinger
4 years, 3 months ago (2016-09-14 20:09:34 UTC) #3
eae
LGTM
4 years, 3 months ago (2016-09-15 09:23:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342663002/20001
4 years, 3 months ago (2016-09-15 12:50:35 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 12:56:04 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 12:57:56 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4567d59b87472d29a1fc660a55cd8aa56c83f280
Cr-Commit-Position: refs/heads/master@{#418846}

Powered by Google App Engine
This is Rietveld 408576698