third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h - Issue 2342663002: [css-flexbox] Fix size comparison when scrollbars are present

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h

Issue 2342663002: [css-flexbox] Fix size comparison when scrollbars are present (Closed)

Patch Set: add test Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h b/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h

index 84fab815a085a7364af93ee24eae1a020e6385b1..485f13d1509ec0a8b5d8e413276ad5cc82270ecd 100644

--- a/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h

+++ b/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h

@@ -121,7 +121,7 @@ private:

LayoutUnit childIntrinsicLogicalHeight(const LayoutBox& child) const;

LayoutUnit childIntrinsicLogicalWidth(const LayoutBox& child) const;

LayoutUnit mainAxisExtentForChild(const LayoutBox& child) const;

- LayoutUnit mainAxisContentExtentForChild(const LayoutBox& child) const;

+ LayoutUnit mainAxisContentExtentForChildIncludingScrollbar(const LayoutBox& child) const;

LayoutUnit crossAxisExtent() const;

LayoutUnit mainAxisExtent() const;

LayoutUnit crossAxisContentExtent() const;