Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2342643003: Always write the source map even if it is inlined. (Closed)

Created:
4 years, 3 months ago by Jacob
Modified:
4 years, 3 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org, vsm
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Always write the source map even if it is inlined. This simplifies bazel rules. BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/35e7c4c5f574bb1949993408d5f087c8a5245ffe

Patch Set 1 #

Patch Set 2 : Always write the source map even if it is inlined. This simplifies bazel rules. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M pkg/dev_compiler/lib/src/compiler/compiler.dart View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Jacob
4 years, 3 months ago (2016-09-15 16:31:50 UTC) #2
Jacob
This simplifies bazel rules.
4 years, 3 months ago (2016-09-15 16:32:13 UTC) #3
Jennifer Messerly
if it helps you LGTM, but would you mind adding a TODO? it seem a ...
4 years, 3 months ago (2016-09-15 16:33:19 UTC) #4
Jacob
added comment // TODO(jacobr): it is a bit strange we are writing the source map ...
4 years, 3 months ago (2016-09-15 16:43:07 UTC) #5
Jacob
4 years, 3 months ago (2016-09-15 17:33:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
35e7c4c5f574bb1949993408d5f087c8a5245ffe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698