Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: pkg/dev_compiler/lib/src/compiler/compiler.dart

Issue 2342643003: Always write the source map even if it is inlined. (Closed)
Patch Set: Always write the source map even if it is inlined. This simplifies bazel rules. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/lib/src/compiler/compiler.dart
diff --git a/pkg/dev_compiler/lib/src/compiler/compiler.dart b/pkg/dev_compiler/lib/src/compiler/compiler.dart
index 7e95a443d85edb7ef0838d2b2840e025f91d073c..bc1ae508c4face902e648266257cce973c0858c9 100644
--- a/pkg/dev_compiler/lib/src/compiler/compiler.dart
+++ b/pkg/dev_compiler/lib/src/compiler/compiler.dart
@@ -436,7 +436,11 @@ class JSModuleFile {
c = 'eval(${JSON.encode(c)});\n';
}
new File(jsPath).writeAsStringSync(c);
- if (code.sourceMap != null && !options.inlineSourceMap) {
+ // TODO(jacobr): it is a bit strange we are writing the source map to a file
+ // even when options.inlineSourceMap is true. To be consistent perhaps we
+ // should also write a copy of the source file without a sourcemap even when
+ // inlineSourceMap is true.
+ if (code.sourceMap != null) {
new File(mapPath).writeAsStringSync(JSON.encode(code.sourceMap));
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698