Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2779)

Unified Diff: chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js

Issue 2342603004: [Offline pages] Clean up unnecessary DeleteAll calls in offline internals (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js
diff --git a/chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js b/chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js
index 4cb46a6140a3139a8e60c6aeaa6d6c0dc23885f8..cbbb2447f17b4baeaeac6a6630ad64037c4dcbfc 100644
--- a/chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js
+++ b/chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js
@@ -57,12 +57,6 @@ cr.define('offlineInternals', function() {
getRequestQueue: function() {},
/**
- * Deletes all the pages in stored pages.
- * @return {!Promise<!string>} A promise firing when the pages are deleted.
- */
- deleteAllPages: function() {},
-
- /**
* Deletes a set of pages from stored pages
* @param {!Array<string>} ids A list of page IDs to delete.
* @return {!Promise<!string>} A promise firing when the selected
@@ -71,12 +65,6 @@ cr.define('offlineInternals', function() {
deleteSelectedPages: function(ids) {},
/**
- * Deletes all the requests from the request queue.
- * @return {!Promise<!string>} A promise firing when the pages are deleted.
- */
- deleteAllRequests: function() {},
-
- /**
* Deletes a set of requests from the request queue
* @param {!Array<string>} ids A list of request IDs to delete.
* @return {!Promise<!string>} A promise firing when the selected
@@ -145,21 +133,11 @@ cr.define('offlineInternals', function() {
},
/** @override */
- deleteAllPages: function() {
- return cr.sendWithPromise('deleteAllPages');
- },
-
- /** @override */
deleteSelectedPages: function(ids) {
return cr.sendWithPromise('deleteSelectedPages', ids);
},
/** @override */
- deleteAllRequests: function() {
- return cr.sendWithPromise('deleteAllRequests');
- },
-
- /** @override */
deleteSelectedRequests: function(ids) {
return cr.sendWithPromise('deleteSelectedRequests', ids);
},

Powered by Google App Engine
This is Rietveld 408576698