Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: chrome/browser/resources/offline_pages/offline_internals.html

Issue 2342603004: [Offline pages] Clean up unnecessary DeleteAll calls in offline internals (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/offline_pages/offline_internals.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/offline_pages/offline_internals.html
diff --git a/chrome/browser/resources/offline_pages/offline_internals.html b/chrome/browser/resources/offline_pages/offline_internals.html
index 6ba2f41a27cdd99fcb39d4f860f7124e53fdc9aa..93f5aed265185369cb867ac7b12430ee2cb919fd 100644
--- a/chrome/browser/resources/offline_pages/offline_internals.html
+++ b/chrome/browser/resources/offline_pages/offline_internals.html
@@ -40,8 +40,8 @@
<h2>Stored Pages</h2>
<div>
- <button id="clear-all">Clear all</button>
- <button id="clear-selected">Clear selected</button>
+ <button id="delete-all-pages">Clear all</button>
dewittj 2016/09/14 18:39:10 nit: why move to "delete" when the model uses "cle
chili 2016/09/14 18:47:07 Request queue uses delete (line 62-63). Whenever
+ <button id="delete-selected-pages">Clear selected</button>
</div>
<table class="stored-pages-table">
<thead>
« no previous file with comments | « no previous file | chrome/browser/resources/offline_pages/offline_internals.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698