Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: BUILD.gn

Issue 2342563002: [d8] Fix the shared-library build (Closed)
Patch Set: Mark as extern in .cc Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | include/v8.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 157617372ebc99039f8166fa7503fde4d6766f9c..141c799a3a71bfc70a2442ad557c7f98cd1570ce 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -115,10 +115,7 @@ config("internal_config") {
include_dirs = [ "." ]
if (is_component_build) {
- defines = [
- "V8_SHARED",
- "BUILDING_V8_SHARED",
- ]
+ defines = [ "BUILDING_V8_SHARED" ]
}
}
@@ -142,10 +139,7 @@ config("libsampler_config") {
# itself.
config("external_config") {
if (is_component_build) {
- defines = [
- "V8_SHARED",
- "USING_V8_SHARED",
- ]
+ defines = [ "USING_V8_SHARED" ]
}
include_dirs = [ "include" ]
if (v8_enable_inspector_override) {
@@ -2389,6 +2383,7 @@ if (is_component_build) {
v8_executable("d8") {
sources = [
+ "$target_gen_dir/d8-js.cc",
"src/d8.cc",
"src/d8.h",
]
@@ -2416,9 +2411,6 @@ v8_executable("d8") {
sources += [ "src/d8-windows.cc" ]
}
- if (!is_component_build) {
- sources += [ "$target_gen_dir/d8-js.cc" ]
- }
if (v8_enable_i18n_support) {
deps += [ "//third_party/icu" ]
}
« no previous file with comments | « no previous file | include/v8.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698