[Offline pages] Use the new policy bits

chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc

Index: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
diff --git a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
index 5b6e72285c1ee2601397e78052b82b452b078dc8..d7672b8d6fb3b8a33c2341c92698d2e42c2722a4 100644
--- a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
+++ b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
@@ -74,8 +74,7 @@ std::vector<int64_t> FilterRequestsByGuid(
   std::vector<int64_t> request_ids;
   for (const auto& request : requests) {
     if (request->client_id().id == guid &&
-        (request->client_id().name_space == kDownloadNamespace ||
-         request->client_id().name_space == kAsyncNamespace)) {
+        DownloadUIAdapter::IsVisibleInUI(request->client_id())) {

[fgorski, 2016/09/19 22:18:54]

Have you considered calling the policy directly here?
What would the trade-offs be?

[chili, 2016/09/20 00:02:33]

At first I picked DownloadUIAdapter because this is the download bridge and it
there was a reference to DownloadUIAdapter.  Later, I realized the IsVisibleInUI
method was static.  In reality though, it's the same effect as calling the
policy directly, minus an extra stack frame.

Taking another look at this, though, this will actually create n policy
controllers, where n is # of requests...  made the change.

       request_ids.push_back(request->request_id());
     }
   }