[Offline pages] Use the new policy bits

chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h"
 
 #include <vector>
 
 #include "base/android/jni_string.h"
 #include "base/bind.h"
@@ skipping 56 matching lines @@
       ConvertUTF8ToJavaString(env, item.target_path.value()),
       item.start_time.ToJavaTime(), item.total_bytes);
 }
 
 std::vector<int64_t> FilterRequestsByGuid(
     std::vector<std::unique_ptr<SavePageRequest>> requests,
     const std::string& guid) {
   std::vector<int64_t> request_ids;
   for (const auto& request : requests) {
     if (request->client_id().id == guid &&
-        (request->client_id().name_space == kDownloadNamespace ||
-         request->client_id().name_space == kAsyncNamespace)) {
+        DownloadUIAdapter::IsVisibleInUI(request->client_id())) {

[fgorski, 2016/09/19 22:18:54]

Have you considered calling the policy directly here?
What would the trade-offs be?

[chili, 2016/09/20 00:02:33]

At first I picked DownloadUIAdapter because this is the download bridge and it
there was a reference to DownloadUIAdapter.  Later, I realized the IsVisibleInUI
method was static.  In reality though, it's the same effect as calling the
policy directly, minus an extra stack frame.

Taking another look at this, though, this will actually create n policy
controllers, where n is # of requests...  made the change.

       request_ids.push_back(request->request_id());
     }
   }
   return request_ids;
 }
 
 void CancelRequestCallback(const RequestQueue::UpdateMultipleRequestResults&) {
   // Results ignored here, as UI uses observer to update itself.
 }
 
@@ skipping 265 matching lines @@
 
   DownloadUIAdapter* adapter =
       DownloadUIAdapter::FromOfflinePageModel(offline_page_model);
 
   return reinterpret_cast<jlong>(
       new OfflinePageDownloadBridge(env, obj, adapter, browser_context));
 }
 
 }  // namespace android
 }  // namespace offline_pages