Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2342433002: Make 'auto' invalid for the 'hyphens' property when no dictionaries (Closed)

Created:
4 years, 3 months ago by kojii
Modified:
4 years, 3 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make 'auto' invalid for the 'hyphens' property when no dictionaries This patch makes the 'auto' value invalid for the 'hyphens' property on platforms that do not support, as discussed in blink-dev[1]. [1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/LsnvY7FFrY0/XfAcOFYYAAAJ BUG=605840 Committed: https://crrev.com/e189162b29b5171e422c041f3b3160e3f79964e6 Cr-Commit-Position: refs/heads/master@{#418900}

Patch Set 1 #

Patch Set 2 : TestExpectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/android/fast/text/hyphens/hyphens-parsing-001-expected.txt View 1 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/fast/text/hyphens/hyphens-parsing-001-expected.txt View 1 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
kojii
PTAL. Does this look valid way to do this?
4 years, 3 months ago (2016-09-14 05:23:39 UTC) #7
Timothy Loh
On 2016/09/14 05:23:39, kojii wrote: > PTAL. Does this look valid way to do this? ...
4 years, 3 months ago (2016-09-14 08:02:21 UTC) #8
kojii
Thank you for having a quick look, will do so.
4 years, 3 months ago (2016-09-14 10:47:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342433002/40001
4 years, 3 months ago (2016-09-15 15:37:26 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 3 months ago (2016-09-15 17:50:25 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 17:52:01 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e189162b29b5171e422c041f3b3160e3f79964e6
Cr-Commit-Position: refs/heads/master@{#418900}

Powered by Google App Engine
This is Rietveld 408576698