Use base::Thread instead of single-threaded SequencedWorkerPool in TestLauncher.

Use base::Thread instead of single-threaded SequencedWorkerPool in TestLauncher.

BUG=646443
Committed: https://crrev.com/17d49a70d15f0084de6006afe9bc7356d0bdcdea
Cr-Commit-Position: refs/heads/master@{#419247}

[gab, 2016-09-16 16:26:09]

Patchset #1 (id:1) has been deleted

[gab, 2016-09-16 16:27:42]

gab@chromium.org changed reviewers:
+ danakj@chromium.org

[gab, 2016-09-16 16:27:43]

Dana PTAL if you don't mind. +CC pawel who's already off to weekend I assume..

Thanks!

[gab, 2016-09-16 16:30:53]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 16:31:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 17:35:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 17:35:15]

Dry run: This issue passed the CQ dry run.

[danakj, 2016-09-16 17:52:49]

LGTM

https://codereview.chromium.org/2342403002/diff/20001/base/test/launcher/test...
File base/test/launcher/test_launcher.cc (right):

https://codereview.chromium.org/2342403002/diff/20001/base/test/launcher/test...
base/test/launcher/test_launcher.cc:1125: DCHECK(!worker_thread_);
nit: how about instead at the top of this method:

DCHECK_NE(!!worker_pool_owner_, !!worker_thread_);

[gab, 2016-09-16 18:09:30]

https://codereview.chromium.org/2342403002/diff/20001/base/test/launcher/test...
File base/test/launcher/test_launcher.cc (right):

https://codereview.chromium.org/2342403002/diff/20001/base/test/launcher/test...
base/test/launcher/test_launcher.cc:1125: DCHECK(!worker_thread_);
On 2016/09/16 17:52:48, danakj wrote:
> nit: how about instead at the top of this method:
> 
> DCHECK_NE(!!worker_pool_owner_, !!worker_thread_);

Nice trick :-), done.

[gab, 2016-09-16 18:09:41]

The CQ bit was checked by gab@chromium.org

[gab, 2016-09-16 18:09:41]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2342403002/#ps40001
(title: "cleaner DCHECKs")

[commit-bot: I haz the power, 2016-09-16 18:10:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 19:24:34]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-09-16 19:28:05]

Description was changed from

==========
Use base::Thread instead of single-threaded SequencedWorkerPool in TestLauncher.

BUG=646443
==========

to

==========
Use base::Thread instead of single-threaded SequencedWorkerPool in TestLauncher.

BUG=646443

Committed: https://crrev.com/17d49a70d15f0084de6006afe9bc7356d0bdcdea
Cr-Commit-Position: refs/heads/master@{#419247}
==========

[commit-bot: I haz the power, 2016-09-16 19:28:06]

Patchset 2 (id:??) landed as
https://crrev.com/17d49a70d15f0084de6006afe9bc7356d0bdcdea
Cr-Commit-Position: refs/heads/master@{#419247}