Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Issue 2330303003: Disallow single-threaded SequencedWorkerPools. (Closed)

Created:
4 years, 3 months ago by gab
Modified:
4 years, 3 months ago
Reviewers:
danakj
CC:
chromium-reviews, fdoray, robliao
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disallow single-threaded SequencedWorkerPools. BUG=646443 Committed: https://crrev.com/37151e9412c1676e78063eed81568c62646724e9 Cr-Commit-Position: refs/heads/master@{#419496}

Patch Set 1 : #

Patch Set 2 : merge up to r419443 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -24 lines) Patch
M base/threading/sequenced_worker_pool.h View 1 2 chunks +6 lines, -7 lines 0 comments Download
M base/threading/sequenced_worker_pool.cc View 1 2 chunks +3 lines, -17 lines 0 comments Download

Messages

Total messages: 35 (26 generated)
gab
Dana PTAL, thanks!
4 years, 3 months ago (2016-09-16 20:20:21 UTC) #18
danakj
LGTM
4 years, 3 months ago (2016-09-16 20:30:24 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330303003/40001
4 years, 3 months ago (2016-09-18 17:30:13 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/270515)
4 years, 3 months ago (2016-09-18 17:32:36 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330303003/60001
4 years, 3 months ago (2016-09-19 13:44:18 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/299957)
4 years, 3 months ago (2016-09-19 15:10:38 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330303003/60001
4 years, 3 months ago (2016-09-19 16:58:15 UTC) #32
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 3 months ago (2016-09-19 17:48:11 UTC) #33
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 17:49:41 UTC) #35
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/37151e9412c1676e78063eed81568c62646724e9
Cr-Commit-Position: refs/heads/master@{#419496}

Powered by Google App Engine
This is Rietveld 408576698