Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: remoting/host/it2me/it2me_confirmation_dialog_android.cc

Issue 2342393003: Removing TODO for It2Me Confirmation Dialog (Closed)
Patch Set: Adding some missing header files. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/host/it2me/it2me_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/it2me/it2me_confirmation_dialog_android.cc
diff --git a/remoting/host/it2me/it2me_confirmation_dialog_android.cc b/remoting/host/it2me/it2me_confirmation_dialog_android.cc
index fba9a043a3dfbb9298656000af0bdc85f612a4cb..40a6d38e08650d022a3767b4c3231f19edd87919 100644
--- a/remoting/host/it2me/it2me_confirmation_dialog_android.cc
+++ b/remoting/host/it2me/it2me_confirmation_dialog_android.cc
@@ -4,10 +4,15 @@
#include "remoting/host/it2me/it2me_confirmation_dialog.h"
+#include <memory>
+
+#include "base/logging.h"
+
namespace remoting {
std::unique_ptr<It2MeConfirmationDialog>
It2MeConfirmationDialogFactory::Create() {
+ NOTIMPLEMENTED();
Sergey Ulanov 2016/09/19 20:56:35 Should this be NOTREACHED()? The calling code does
joedow 2016/09/20 03:23:41 I added it to make things simpler if we decided to
return nullptr;
}
« no previous file with comments | « no previous file | remoting/host/it2me/it2me_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698