remoting/host/it2me/it2me_confirmation_dialog_android.cc - Issue 2342393003: Removing TODO for It2Me Confirmation Dialog

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/host/it2me/it2me_confirmation_dialog_android.cc

Issue 2342393003: Removing TODO for It2Me Confirmation Dialog (Closed)

Patch Set: Adding some missing header files. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "remoting/host/it2me/it2me_confirmation_dialog.h"	5 #include "remoting/host/it2me/it2me_confirmation_dialog.h"

6	6

	7 #include <memory>

	8

	9 #include "base/logging.h"

	10

7 namespace remoting {	11 namespace remoting {

8	12

9 std::unique_ptr<It2MeConfirmationDialog>	13 std::unique_ptr<It2MeConfirmationDialog>

10 It2MeConfirmationDialogFactory::Create() {	14 It2MeConfirmationDialogFactory::Create() {

	15 NOTIMPLEMENTED();
	Sergey Ulanov 2016/09/19 20:56:35 Should this be NOTREACHED()? The calling code does Should this be NOTREACHED()? The calling code doesn't expect nullptr result. OTOH we shouldn't be compiling host on android, so I'm not sure we even need this file. joedow 2016/09/20 03:23:41 I added it to make things simpler if we decided to Show quoted text On 2016/09/19 20:56:35, Sergey Ulanov wrote: > Should this be NOTREACHED()? The calling code doesn't expect nullptr result. > OTOH we shouldn't be compiling host on android, so I'm not sure we even need > this file. I added it to make things simpler if we decided to proceed with the Android host in the future, since you and Lambros are both suggesting I remove it then I am happy to do so.
11 return nullptr;	16 return nullptr;

12 }	17 }

13	18

14 } // namespace remoting	19 } // namespace remoting

OLD	NEW

« no previous file with comments | « no previous file | remoting/host/it2me/it2me_host.cc » ('j') | no next file with comments »