third_party/WebKit/Source/modules/webmidi/MIDIConnectionEventInit.idl - Issue 2342393002: Enable TypeError for dictionary members of non-nullable interface type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webmidi/MIDIConnectionEventInit.idl

Issue 2342393002: Enable TypeError for dictionary members of non-nullable interface type (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/vr/VRDisplayEventInit.idl ('k') | third_party/WebKit/Source/modules/webmidi/MIDIMessageEventInit.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webmidi/MIDIConnectionEventInit.idl

diff --git a/third_party/WebKit/Source/modules/webmidi/MIDIConnectionEventInit.idl b/third_party/WebKit/Source/modules/webmidi/MIDIConnectionEventInit.idl

index 3e539cefb928b7904808eff9822c9d42eac5402b..d47f755f5d7f2893cfdde3ef0b220aff28dfc4fa 100644

--- a/third_party/WebKit/Source/modules/webmidi/MIDIConnectionEventInit.idl

+++ b/third_party/WebKit/Source/modules/webmidi/MIDIConnectionEventInit.idl

@@ -5,5 +5,8 @@

// http://webaudio.github.io/web-midi-api/#idl-def-MIDIConnectionEventInit

dictionary MIDIConnectionEventInit : EventInit {

- MIDIPort port;

+ // TODO(foolip): |port| should be required and not nullable.

+ // https://crbug.com/647693

+ // https://github.com/WebAudio/web-midi-api/issues/168

+ MIDIPort? port;

};